Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: components/metrics/metrics_provider.h

Issue 1891913002: Support saving browser metrics to disk and reading them during next run. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove DCHECK_IS_ON from .h files because it's not always defined and don't want to add the include Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_METRICS_METRICS_PROVIDER_H_ 5 #ifndef COMPONENTS_METRICS_METRICS_PROVIDER_H_
6 #define COMPONENTS_METRICS_METRICS_PROVIDER_H_ 6 #define COMPONENTS_METRICS_METRICS_PROVIDER_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 9
10 namespace base { 10 namespace base {
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 // Called to indicate that saved stability prefs should be cleared, e.g. 63 // Called to indicate that saved stability prefs should be cleared, e.g.
64 // because they are from an old version and should not be kept. 64 // because they are from an old version and should not be kept.
65 virtual void ClearSavedStabilityMetrics(); 65 virtual void ClearSavedStabilityMetrics();
66 66
67 // Provides general metrics that are neither system profile nor stability 67 // Provides general metrics that are neither system profile nor stability
68 // metrics. May also be used to add histograms when final metrics are 68 // metrics. May also be used to add histograms when final metrics are
69 // collected right before upload. 69 // collected right before upload.
70 virtual void ProvideGeneralMetrics( 70 virtual void ProvideGeneralMetrics(
71 ChromeUserMetricsExtension* uma_proto); 71 ChromeUserMetricsExtension* uma_proto);
72 72
73 // Called during collection to explicitly load histogram snapshots using a 73 // Called during regular collection to explicitly load histogram snapshots
74 // snapshot manager. PrepareDeltas() will have already been called and 74 // using a snapshot manager. PrepareDeltas() will have already been called
75 // FinishDeltas() will be called later; calls to only PrepareDelta(), not 75 // and FinishDeltas() will be called later; calls to only PrepareDelta(),
76 // PrepareDeltas (plural), should be made. 76 // not PrepareDeltas (plural), should be made.
77 virtual void RecordHistogramSnapshots( 77 virtual void RecordHistogramSnapshots(
78 base::HistogramSnapshotManager* snapshot_manager); 78 base::HistogramSnapshotManager* snapshot_manager);
79 79
80 // Called during collection of "stability" metrics to explicitly load
Ilya Sherman 2016/05/04 06:48:08 It's not actually "stability" that's relevant her.
bcwhite 2016/05/04 14:12:51 Done.
81 // histogram snapshots using a snapshot manager. PrepareDeltas() will have
82 // already been called and FinishDeltas() will be called later; calls to
83 // only PrepareDelta(), not PrepareDeltas (plural), should be made.
84 virtual void RecordStabilityHistogramSnapshots(
85 base::HistogramSnapshotManager* snapshot_manager);
86
80 private: 87 private:
81 DISALLOW_COPY_AND_ASSIGN(MetricsProvider); 88 DISALLOW_COPY_AND_ASSIGN(MetricsProvider);
82 }; 89 };
83 90
84 } // namespace metrics 91 } // namespace metrics
85 92
86 #endif // COMPONENTS_METRICS_METRICS_PROVIDER_H_ 93 #endif // COMPONENTS_METRICS_METRICS_PROVIDER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698