components/autofill/core/browser/autofill_profile.cc - Issue 1891903002: [Autofill] Set basic information when adding a new profiles and credit cards.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_profile.cc

Issue 1891903002: [Autofill] Set basic information when adding a new profiles and credit cards. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/core/browser/autofill_manager_unittest.cc ('K') | « components/autofill/core/browser/autofill_manager_unittest.cc ('k') | components/autofill/core/browser/personal_data_manager_unittest.cc » ('j') | components/autofill/core/browser/webdata/autofill_profile_syncable_service_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_profile.cc

diff --git a/components/autofill/core/browser/autofill_profile.cc b/components/autofill/core/browser/autofill_profile.cc

index 86d3e4c05833df0df077c40ea7b75a70aecb292e..a1c72840af573dc34ba911abb568b1f82c769de9 100644

--- a/components/autofill/core/browser/autofill_profile.cc

+++ b/components/autofill/core/browser/autofill_profile.cc

@@ -520,7 +520,8 @@ bool AutofillProfile::OverwriteWith(const AutofillProfile& profile,

DCHECK(!IsVerified() || profile.IsVerified());

set_origin(profile.origin());

set_language_code(profile.language_code());

- set_use_count(profile.use_count() + use_count());

+ if (profile.use_count() > use_count())

Mathieu 2016/04/19 14:29:35 as discussed, let's keep the + here.

sebsg 2016/04/20 20:25:46 Done.

+ set_use_count(profile.use_count());

if (profile.use_date() > use_date())

set_use_date(profile.use_date());