Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 1891883002: Clean up logic to determine if a navigation is from GWS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gwsabort
Patch Set: Address comment. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 8c2e4430cd9743a675273cbb408994ecd291232d..045660f82feaa2ce183eb6e103efc312b17b1786 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -91386,18 +91386,21 @@ To add a new entry, add it with any value and run test to compute valid value.
ordering="prefix">
<suffix name="Clients.FromGWS"
label="PageLoadMetrics that are a result of a navigation from a Google
+ web search">
+ <obsolete>
+ Deprecated in favor of Clients.FromGWS2.
+ </obsolete>
+ </suffix>
+ <suffix name="Clients.FromGWS2"
+ label="PageLoadMetrics that are a result of a navigation from a Google
web search"/>
<suffix name="Clients.DocWrite.Evaluator"
label="PageLoadMetrics from a page that could have been evaluated by
the DocumentWriteEvaluator"/>
<affected-histogram
- name="PageLoad.Timing2.DOMLoadingToDOMContentLoadedEventFired"/>
- <affected-histogram name="PageLoad.Timing2.DOMLoadingToFirstContentfulPaint"/>
- <affected-histogram
name="PageLoad.Timing2.NavigationToDOMContentLoadedEventFired"/>
<affected-histogram name="PageLoad.Timing2.NavigationToFirstContentfulPaint"/>
<affected-histogram name="PageLoad.Timing2.NavigationToFirstImagePaint"/>
- <affected-histogram name="PageLoad.Timing2.NavigationToFirstLayout"/>
Alexei Svitkine (slow) 2016/04/19 19:57:55 What's the reason for removing these? If these we
Bryan McQuade 2016/04/19 20:04:51 We're deprecating these, but that's really separat
<affected-histogram name="PageLoad.Timing2.NavigationToFirstPaint"/>
<affected-histogram name="PageLoad.Timing2.NavigationToFirstTextPaint"/>
<affected-histogram name="PageLoad.Timing2.NavigationToLoadEventFired"/>
« no previous file with comments | « chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698