Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 1891873002: SkPDF: PDF/A runtime switch (Closed)

Created:
4 years, 8 months ago by hal.canary
Modified:
4 years, 8 months ago
Reviewers:
djsollen, tomhudson
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkPDF: PDF/A runtime switch TODO: remove gyp variable and modify API in SkDocument.h SkMD5 now moved into core as pdf depends on it now. BUG=skia:3110 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1891873002 Committed: https://skia.googlesource.com/skia/+/570f18b43417d73c3fbd113cc0b4258e08b14c82 Committed: https://skia.googlesource.com/skia/+/488165e689baf0f215d5798c87d0031b58e4bc8d

Patch Set 1 : 2016-04-14 (Thursday) 17:02:04 EDT #

Patch Set 2 : 2016-04-21 (Thursday) 16:21:36 EDT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -492 lines) Patch
M bench/PDFBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gyp/core.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
A + src/core/SkMD5.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/core/SkMD5.cpp View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pdf/SkPDFDevice.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M src/pdf/SkPDFDocument.h View 3 chunks +5 lines, -4 lines 0 comments Download
M src/pdf/SkPDFDocument.cpp View 8 chunks +151 lines, -164 lines 0 comments Download
M src/pdf/SkPDFMetadata.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/pdf/SkPDFMetadata.cpp View 3 chunks +1 line, -7 lines 0 comments Download
M src/utils/SkMD5.h View 1 1 chunk +1 line, -61 lines 0 comments Download
M src/utils/SkMD5.cpp View 1 1 chunk +1 line, -252 lines 0 comments Download

Messages

Total messages: 48 (27 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1891873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1891873002/1
4 years, 8 months ago (2016-04-14 18:27:19 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot/builds/7859)
4 years, 8 months ago (2016-04-14 18:34:26 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1891873002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1891873002/20001
4 years, 8 months ago (2016-04-14 19:07:25 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_64-Release-Trybot/builds/1960) Build-Ubuntu-GCC-x86_64-Release-Trybot on ...
4 years, 8 months ago (2016-04-14 19:08:33 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1891873002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1891873002/40001
4 years, 8 months ago (2016-04-14 19:10:03 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-14 19:19:14 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1891873002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1891873002/60001
4 years, 8 months ago (2016-04-14 20:54:02 UTC) #19
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1891873002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1891873002/100001
4 years, 8 months ago (2016-04-14 21:02:28 UTC) #22
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/7860)
4 years, 8 months ago (2016-04-14 21:07:59 UTC) #25
hal.canary
PTAL reed@ wants a runtime switch for PDF/A. This makes sense since it will prevent ...
4 years, 8 months ago (2016-04-15 17:05:31 UTC) #27
tomhudson
lgtm
4 years, 8 months ago (2016-04-15 18:58:14 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1891873002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1891873002/100001
4 years, 8 months ago (2016-04-15 18:58:25 UTC) #30
commit-bot: I haz the power
Committed patchset #1 (id:100001) as https://skia.googlesource.com/skia/+/570f18b43417d73c3fbd113cc0b4258e08b14c82
4 years, 8 months ago (2016-04-15 18:59:35 UTC) #32
hal.canary
A revert of this CL (patchset #1 id:100001) has been created in https://codereview.chromium.org/1892203002/ by halcanary@google.com. ...
4 years, 8 months ago (2016-04-15 19:30:02 UTC) #33
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1891873002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1891873002/120001
4 years, 8 months ago (2016-04-21 20:22:14 UTC) #36
hal.canary
This may fix this.
4 years, 8 months ago (2016-04-21 20:26:05 UTC) #39
tomhudson
On 2016/04/21 20:26:05, Hal Canary wrote: > This may fix this. Moved MD5 from src/utils ...
4 years, 8 months ago (2016-04-21 20:33:04 UTC) #40
hal.canary
On 2016/04/21 20:33:04, tomhudson wrote: > On 2016/04/21 20:26:05, Hal Canary wrote: > > This ...
4 years, 8 months ago (2016-04-21 20:49:47 UTC) #41
hal.canary
with no objections, I'm going to land this.
4 years, 8 months ago (2016-04-22 13:09:09 UTC) #43
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1891873002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1891873002/120001
4 years, 8 months ago (2016-04-22 13:09:26 UTC) #46
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 13:10:26 UTC) #48
Message was sent while issue was closed.
Committed patchset #2 (id:120001) as
https://skia.googlesource.com/skia/+/488165e689baf0f215d5798c87d0031b58e4bc8d

Powered by Google App Engine
This is Rietveld 408576698