Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1891863002: 🐘 Make --executable-dist-dir a path arg for android test wrapper scripts (Closed)

Created:
4 years, 8 months ago by agrieve
Modified:
4 years, 8 months ago
Reviewers:
Yaron
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make --executable-dist-dir a path arg for android test wrapper scripts It was co-incidentally working for me previously because I had my CWD=output-dir. BUG=599919 Committed: https://crrev.com/4acf218ca0a7b4f001750ef889f1116ef835a272 Cr-Commit-Position: refs/heads/master@{#387376}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M build/android/gyp/create_test_runner_script.py View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
agrieve
On 2016/04/14 17:16:04, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:yfriedman@chromium.org
4 years, 8 months ago (2016-04-14 17:16:09 UTC) #3
Yaron
lgtm
4 years, 8 months ago (2016-04-14 17:26:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1891863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1891863002/1
4 years, 8 months ago (2016-04-14 17:41:43 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-14 18:43:17 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 18:44:43 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4acf218ca0a7b4f001750ef889f1116ef835a272
Cr-Commit-Position: refs/heads/master@{#387376}

Powered by Google App Engine
This is Rietveld 408576698