Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Unified Diff: headless/public/headless_browser.h

Issue 1891843004: [headless] AddWindowTreeClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added tests and changed ownership model Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: headless/public/headless_browser.h
diff --git a/headless/public/headless_browser.h b/headless/public/headless_browser.h
index 011017471e1f86e5d803ea1bdd0ce14b4816d71e..909ff30a28c88e08c29c1224ebd83a02952ae3fb 100644
--- a/headless/public/headless_browser.h
+++ b/headless/public/headless_browser.h
@@ -37,9 +37,10 @@ class HEADLESS_EXPORT HeadlessBrowser {
// Create a new browser tab which navigates to |initial_url|. |size| is in
// physical pixels.
Sami 2016/04/20 16:38:50 Could you mention that the browser owns the return
altimin 2016/04/20 17:35:25 Done.
- virtual std::unique_ptr<HeadlessWebContents> CreateWebContents(
- const GURL& initial_url,
- const gfx::Size& size) = 0;
+ virtual HeadlessWebContents* CreateWebContents(const GURL& initial_url,
+ const gfx::Size& size) = 0;
+
+ virtual std::vector<HeadlessWebContents*> GetAllWebContents() = 0;
// Returns a task runner for submitting work to the browser main thread.
virtual scoped_refptr<base::SingleThreadTaskRunner> BrowserMainThread()

Powered by Google App Engine
This is Rietveld 408576698