headless/app/headless_shell.cc - Issue 1891843004: [headless] AddWindowTreeClient

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: headless/app/headless_shell.cc

Issue 1891843004: [headless] AddWindowTreeClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added tests and changed ownership model Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: headless/app/headless_shell.cc

diff --git a/headless/app/headless_shell.cc b/headless/app/headless_shell.cc

index 1031dbd5446b78a4fa95d7981971fc1a9faca677..76c970318708d61a0bb0bc3c2878e44dde470dd3 100644

--- a/headless/app/headless_shell.cc

+++ b/headless/app/headless_shell.cc

@@ -73,7 +73,7 @@ class HeadlessShell : public HeadlessWebContents::Observer {

private:

HeadlessBrowser* browser_; // Not owned.

- std::unique_ptr<HeadlessWebContents> web_contents_;

+ HeadlessWebContents* web_contents_;

DISALLOW_COPY_AND_ASSIGN(HeadlessShell);

};