Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Unified Diff: headless/public/headless_browser.h

Issue 1891843004: [headless] AddWindowTreeClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase to latest master Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « headless/lib/headless_web_contents_browsertest.cc ('k') | headless/public/headless_web_contents.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: headless/public/headless_browser.h
diff --git a/headless/public/headless_browser.h b/headless/public/headless_browser.h
index 011017471e1f86e5d803ea1bdd0ce14b4816d71e..b8c4f93d821328c03701eb9c34c1aee3b1fc8466 100644
--- a/headless/public/headless_browser.h
+++ b/headless/public/headless_browser.h
@@ -37,9 +37,13 @@ class HEADLESS_EXPORT HeadlessBrowser {
// Create a new browser tab which navigates to |initial_url|. |size| is in
// physical pixels.
- virtual std::unique_ptr<HeadlessWebContents> CreateWebContents(
- const GURL& initial_url,
- const gfx::Size& size) = 0;
+ // We require the user to pass an initial URL to ensure that the renderer
+ // gets initialized and eventually becomes ready to be inspected. See
+ // HeadlessWebContents::Observer::DevToolsTargetReady.
+ virtual HeadlessWebContents* CreateWebContents(const GURL& initial_url,
+ const gfx::Size& size) = 0;
+
+ virtual std::vector<HeadlessWebContents*> GetAllWebContents() = 0;
// Returns a task runner for submitting work to the browser main thread.
virtual scoped_refptr<base::SingleThreadTaskRunner> BrowserMainThread()
« no previous file with comments | « headless/lib/headless_web_contents_browsertest.cc ('k') | headless/public/headless_web_contents.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698