Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 1891843002: [Media Router WebUI] Fix non-blocking issue banner styling. (Closed)

Created:
4 years, 8 months ago by apacible
Modified:
4 years, 8 months ago
Reviewers:
mark a. foltz
CC:
arv+watch_chromium.org, chromium-reviews, media-router+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router WebUI] Fix non-blocking issue banner styling. This change makes the banner span the full dialog. BUG=603379 Committed: https://crrev.com/62b1eab330b8b9c6d54c65848a2786a0c73a1757 Cr-Commit-Position: refs/heads/master@{#387414}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/resources/media_router/elements/issue_banner/issue_banner.css View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
apacible
PTAL, thanks! LTR: Blocking, 1 Action:https://screenshot.googleplex.com/BBuMK5fdAHH.png Blocking, 2 Actions: https://screenshot.googleplex.com/LF9STB3cEJP.png Non-Blocking, 1 Action: https://screenshot.googleplex.com/wwiFjSdaiks.png Non-Blocking, ...
4 years, 8 months ago (2016-04-14 16:38:22 UTC) #3
mark a. foltz
lgtm
4 years, 8 months ago (2016-04-14 18:38:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1891843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1891843002/1
4 years, 8 months ago (2016-04-14 20:37:04 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-14 20:45:05 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 20:46:20 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/62b1eab330b8b9c6d54c65848a2786a0c73a1757
Cr-Commit-Position: refs/heads/master@{#387414}

Powered by Google App Engine
This is Rietveld 408576698