MacViews: Fix BubbleDialogDelegateTest.CloseMethods

ui/views/bubble/bubble_dialog_delegate_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/bubble/bubble_dialog_delegate.h"
 
 #include <stddef.h>
 
 #include "base/macros.h"
 #include "ui/base/hit_test.h"
@@ skipping 270 matching lines @@
     anchor_widget->Activate();
     EXPECT_TRUE(bubble_widget->IsClosed());
   }
 
   {
     std::unique_ptr<Widget> anchor_widget(CreateTestWidget());
     BubbleDialogDelegateView* bubble_delegate =
         new TestBubbleDialogDelegateView(anchor_widget->GetContentsView());
     Widget* bubble_widget =
         BubbleDialogDelegateView::CreateBubble(bubble_delegate);
+    anchor_widget->Show();
     bubble_widget->Show();
 
     ui::KeyEvent escape_event(ui::ET_KEY_PRESSED, ui::VKEY_ESCAPE, ui::EF_NONE);
     bubble_widget->OnKeyEvent(&escape_event);
     EXPECT_TRUE(bubble_widget->IsClosed());
   }
 
   {
     std::unique_ptr<Widget> anchor_widget(CreateTestWidget());
     TestBubbleDialogDelegateView* bubble_delegate =
         new TestBubbleDialogDelegateView(anchor_widget->GetContentsView());
     Widget* bubble_widget =
         BubbleDialogDelegateView::CreateBubble(bubble_delegate);
     bubble_widget->Show();

[tapted, 2016/04/15 00:47:27]

hum - this should need it too. I guess the particular things being tested don't
require the widget to be shown since the events are send directly. But that
might mean we are missing out on test coverage for a lot of these, and things
are just passing by chance.

Can you experiment with calling Show() inside CreateTestWidget(), and removing
the calls to anchor_widget->Show() from all the tests?

There might be a regression, or perhaps a test explicitly wants a hidden parent,
and to show it at a particular time. But I had a quick skim and it looks like
the default case should really be to show the widgets being created by
CreateTestWidget() by default.

[Patti Lor, 2016/04/20 04:39:53]

Done.

     BubbleFrameView* frame_view = bubble_delegate->GetBubbleFrameView();
     LabelButton* close_button = frame_view->close_;
     ASSERT_TRUE(close_button);
     frame_view->ButtonPressed(
         close_button,
         ui::MouseEvent(ui::ET_MOUSE_PRESSED, gfx::Point(), gfx::Point(),
                        ui::EventTimeForNow(), ui::EF_NONE, ui::EF_NONE));
     EXPECT_TRUE(bubble_widget->IsClosed());
   }
 }
 
 }  // namespace views