Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 1891783002: Support multiple fragmentainer groups per ColumnBalancer run. (Closed)

Created:
4 years, 8 months ago by mstensho (USE GERRIT)
Modified:
4 years, 8 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, mstensho (USE GERRIT), pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support multiple fragmentainer groups per ColumnBalancer run. Instead of specifying a fragmentainer group for the operation, we now specify a column set and a flow thread portion (which may be the portion of one group or many contiguous groups within the same column set). The reason for this change is that when calculating space shortage in an inner multicol container, we need to walk through all fragmentainer groups in one operation, or we'll miss the column boundaries between the fragmentainer groups, and only find those that lie between two columns in the same fragmentainer group. This is especially bad if the inner multicol container only has one column per fragmentainer group (row), since then *all* column boundaries lie between two fragmentainer groups, and we wouldn't be able to find any shortage at all. BUG=594833 Committed: https://crrev.com/5b65a57f38f0260e21b8ec190d201ae2504d73e5 Cr-Commit-Position: refs/heads/master@{#388070}

Patch Set 1 #

Messages

Total messages: 8 (3 generated)
mstensho (USE GERRIT)
4 years, 8 months ago (2016-04-15 09:05:03 UTC) #2
leviw_travelin_and_unemployed
lgtm
4 years, 8 months ago (2016-04-18 21:57:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1891783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1891783002/1
4 years, 8 months ago (2016-04-18 21:57:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 23:16:26 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 23:18:13 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5b65a57f38f0260e21b8ec190d201ae2504d73e5
Cr-Commit-Position: refs/heads/master@{#388070}

Powered by Google App Engine
This is Rietveld 408576698