Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: content/browser/find_request_manager.h

Issue 1891773002: Implement the basic testing infrastructure for FindRequestManager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments by nasko@. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/find_request_manager.cc » ('j') | content/browser/find_request_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/find_request_manager.h
diff --git a/content/browser/find_request_manager.h b/content/browser/find_request_manager.h
index 0fa037eb79dc715bddb6a79c8bb0662649afd0fc..a76641b764a0853f843ea709308fa6d646db5c4d 100644
--- a/content/browser/find_request_manager.h
+++ b/content/browser/find_request_manager.h
@@ -8,6 +8,7 @@
#include <set>
#include <vector>
+#include "content/common/content_export.h"
#include "content/public/common/stop_find_action.h"
#include "third_party/WebKit/public/web/WebFindOptions.h"
#include "ui/gfx/geometry/rect.h"
@@ -26,16 +27,16 @@ class WebContentsImpl;
//
// TODO(paulmeyer): FindRequestManager is currently incomplete and does not do
// all of these things yet, but will soon.
-class FindRequestManager {
+class CONTENT_EXPORT FindRequestManager {
public:
explicit FindRequestManager(WebContentsImpl* web_contents);
- ~FindRequestManager();
+ virtual ~FindRequestManager();
nasko 2016/04/18 21:02:39 We no longer need these extra virtuals, as there i
paulmeyer 2016/04/19 15:15:00 That's right. Done.
// Initiates a find operation for |search_text| with the options specified in
// |options|. |request_id| uniquely identifies the find request.
- void Find(int request_id,
- const base::string16& search_text,
- const blink::WebFindOptions& options);
+ virtual void Find(int request_id,
+ const base::string16& search_text,
+ const blink::WebFindOptions& options);
// Stops the active find session and clears the general highlighting of the
// matches. |action| determines whether the last active match (if any) will be
@@ -67,7 +68,7 @@ class FindRequestManager {
const gfx::RectF& active_rect);
#endif
- private:
+ protected:
// An invalid ID. This value is invalid for any render process ID, render
// frame ID, or find request ID.
static const int kInvalidId;
@@ -101,7 +102,7 @@ class FindRequestManager {
void Reset(const FindRequest& initial_request);
// Send the find results (as they currently are) to the WebContents.
- void NotifyFindReply(int request_id, bool final_update) const;
+ virtual void NotifyFindReply(int request_id, bool final_update) const;
#if defined(OS_ANDROID)
// Request the latest find match rects from a frame.
« no previous file with comments | « no previous file | content/browser/find_request_manager.cc » ('j') | content/browser/find_request_manager.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698