content/browser/find_request_manager.cc - Issue 1891773002: Implement the basic testing infrastructure for FindRequestManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/find_request_manager.cc

Issue 1891773002: Implement the basic testing infrastructure for FindRequestManager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added comment to describe TestFindRequestManager. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/find_request_manager.h ('k') | content/browser/find_request_manager_browsertest.cc » ('j') | content/browser/find_request_manager_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/find_request_manager.cc

diff --git a/content/browser/find_request_manager.cc b/content/browser/find_request_manager.cc

index ad6b24e14371b7986725e79fc34521f8577bfca2..a43bef78e8feb073905ee8718f6a81ffc88bdc25 100644

--- a/content/browser/find_request_manager.cc

+++ b/content/browser/find_request_manager.cc

@@ -64,9 +64,12 @@ void FindRequestManager::OnFindReply(RenderFrameHost* rfh,

return;

// Update the stored results.

- number_of_matches_ = number_of_matches;

- selection_rect_ = selection_rect;

- active_match_ordinal_ = active_match_ordinal;

+ if (number_of_matches != -1)

+ number_of_matches_ = number_of_matches;

+ if (!selection_rect.IsEmpty())

+ selection_rect_ = selection_rect;

+ if (active_match_ordinal > 0)

+ active_match_ordinal_ = active_match_ordinal;

NotifyFindReply(request_id, final_update);

}