Implement the basic testing infrastructure for FindRequestManager.

content/browser/find_request_manager.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/find_request_manager.h"
 
 #include "content/browser/frame_host/render_frame_host_impl.h"
 #include "content/browser/web_contents/web_contents_impl.h"
 #include "content/common/frame_messages.h"
 #include "content/common/input_messages.h"
@@ skipping 46 matching lines @@
                                      int request_id,
                                      int number_of_matches,
                                      const gfx::Rect& selection_rect,
                                      int active_match_ordinal,
                                      bool final_update) {
   // Ignore stale replies from abandoned find sessions.
   if (current_session_id_ == kInvalidId || request_id < current_session_id_)
     return;
 
   // Update the stored results.
-  number_of_matches_ = number_of_matches;
-  selection_rect_ = selection_rect;
-  active_match_ordinal_ = active_match_ordinal;
+  if (number_of_matches != -1)
+    number_of_matches_ = number_of_matches;
+  if (!selection_rect.IsEmpty())
+    selection_rect_ = selection_rect;
+  if (active_match_ordinal > 0)
+    active_match_ordinal_ = active_match_ordinal;

[nasko, 2016/04/18 21:02:39]

See my comment in the test file. Updating these conditionally for each variable
can lead to storing values from different IPCs.

[paulmeyer, 2016/04/19 15:15:00]

This was intentional, and is something that FindRequestManager will do
eventually, but I'll leave it out until it's needed. Something similar will
still be needed in the TestWebContentsDelegate though (see comment there).

 
   NotifyFindReply(request_id, final_update);
 }
 
 #if defined(OS_ANDROID)
 void FindRequestManager::ActivateNearestFindResult(float x,
                                                    float y) {
   if (current_session_id_ == kInvalidId)
     return;
 
@@ skipping 50 matching lines @@
 }
 
 #if defined(OS_ANDROID)
 void FindRequestManager::SendFindMatchRectsIPC(RenderFrameHost* rfh) {
   rfh->Send(new FrameMsg_FindMatchRects(rfh->GetRoutingID(),
                                         match_rects_.request_version));
 }
 #endif
 
 }  // namespace content