Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1891753002: [compiler] Remove obsolete MaybeDisableOptimization. (Closed)

Created:
4 years, 8 months ago by Michael Starzinger
Modified:
4 years, 8 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Remove obsolete MaybeDisableOptimization. The parser no longer disables optimization. This is done solely by the renumbering stage. It is sufficient to mark a SharedFunctionInfo as disabled for optimization right after the renumbering stage. R=bmeurer@chromium.org Committed: https://crrev.com/b62af118f421551b261cfee2b943289b0219ca5e Cr-Commit-Position: refs/heads/master@{#35490}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -11 lines) Patch
M src/compiler.cc View 3 chunks +4 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
4 years, 8 months ago (2016-04-14 12:24:20 UTC) #1
Benedikt Meurer
lgtm
4 years, 8 months ago (2016-04-14 12:27:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1891753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1891753002/1
4 years, 8 months ago (2016-04-14 12:29:30 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-14 12:31:08 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 12:32:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b62af118f421551b261cfee2b943289b0219ca5e
Cr-Commit-Position: refs/heads/master@{#35490}

Powered by Google App Engine
This is Rietveld 408576698