src/objects-inl.h - Issue 18917003: A bug in AllocationSite::GetMode(from, to) meant that we didn't update

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-inl.h

Issue 18917003: A bug in AllocationSite::GetMode(from, to) meant that we didn't update (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects-inl.h

diff --git a/src/objects-inl.h b/src/objects-inl.h

index f25112939cada014a807e9c7c35d2d61d8230a75..ae96c24c7283c61d76aee2d0b2256deac933c5b5 100644

--- a/src/objects-inl.h

+++ b/src/objects-inl.h

@@ -1335,7 +1335,8 @@ AllocationSiteMode AllocationSite::GetMode(ElementsKind from,

ElementsKind to) {

if (FLAG_track_allocation_sites &&

IsFastSmiElementsKind(from) &&

- (IsFastObjectElementsKind(to) || IsFastDoubleElementsKind(to))) {

+ IsFastElementsKind(to) &&

+ from != to) {

Toon Verwaest 2013/07/11 09:35:08 Use IsMoreGeneralElementsKind to ensure we never t

mvstanton 2013/07/11 13:01:33 Done.

return TRACK_ALLOCATION_SITE;

}

« no previous file with comments | « no previous file | test/mjsunit/allocation-site-info.js » ('j') | no next file with comments »