Reland of "[heap] Better integrate handling of aborted compaction pages"

Reland of "[heap] Better integrate handling of aborted compaction pages"

- Get rid of fixing up pointers on the main thread
- Get rid of sweeping on the main thread

Instead:
- Record (and process afterwards) slots in parallel
- Add the pages to the concurrent sweeper as pointers have already been fixed

This reverts commit 6df04b296b87e1dad7eb4383167553e721e5fbd8.

BUG=chromium:581412
LOG=N
TEST=cctest/test-compaction/*

Committed: https://crrev.com/3ace01d1b33faed8f67bfa8a7fb04b118caafe3a
Cr-Commit-Position: refs/heads/master@{#35485}

[Michael Lippautz, 2016-04-14 06:57:08]

Description was changed from

==========
Reland of "[heap] Better integrate handling of aborted compaction pages"

This reverts commit 6df04b296b87e1dad7eb4383167553e721e5fbd8.

BUG=
==========

to

==========
Reland of "[heap] Better integrate handling of aborted compaction pages"

- Get rid of fixing up pointers on the main thread
- Get rid of sweeping on the main thread

Instead:
- Record (and process afterwards) slots in parallel
- Add the pages to the concurrent sweeper as pointers have already been fixed

This reverts commit 6df04b296b87e1dad7eb4383167553e721e5fbd8.

BUG=chromium:581412
LOG=N
TEST=cctest/test-compaction/*
==========

[Michael Lippautz, 2016-04-14 07:13:50]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-14 07:13:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1891683002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1891683002/20001

[commit-bot: I haz the power, 2016-04-14 07:44:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-14 07:44:21]

Dry run: This issue passed the CQ dry run.

[Michael Lippautz, 2016-04-14 07:50:10]

mlippautz@chromium.org changed reviewers:
+ hpayer@chromium.org

[Michael Lippautz, 2016-04-14 07:50:11]

ptal, this was a combination of 2 bugs:
- to early sweeping
- not recording typed slots for code space for aborted pages

https://codereview.chromium.org/1891683002/diff/20001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/1891683002/diff/20001/src/heap/mark-compact.c...
src/heap/mark-compact.cc:1833: RememberedSet<OLD_TO_OLD>::InsertTyped(
We also need to record within CODE_SPACE. I am using the hammer
(RELOCATED_CODE_OBJECT) instead of beefing up RecordMigratedSlotVisitor. (Same
as we do in MigrateObject).

https://codereview.chromium.org/1891683002/diff/20001/src/heap/mark-compact.c...
src/heap/mark-compact.cc:3204: // sweeper.
We cannot add the page to the sweeper here because we still require forward
pointers to be fixed during pointer updates (basically: update between
evacuated)

https://codereview.chromium.org/1891683002/diff/20001/src/heap/mark-compact.c...
src/heap/mark-compact.cc:3473: for (Page* p : evacuation_candidates_) {
Moving this part to MC_EVACUATE_CLEAN_UP as it has nothing to do with the
previous phase anymore.

MC_EVACUATE_UPDATE_POINTERS_BETWEEN_EVACUATED does not exist anymore as we do
all necessary pointer updating in parallel in the preceding phases.

[Hannes Payer (out of office), 2016-04-14 10:50:37]

lgtm

[Michael Lippautz, 2016-04-14 11:04:16]

The CQ bit was checked by mlippautz@chromium.org

[commit-bot: I haz the power, 2016-04-14 11:04:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1891683002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1891683002/20001

[commit-bot: I haz the power, 2016-04-14 11:06:26]

Description was changed from

==========
Reland of "[heap] Better integrate handling of aborted compaction pages"

- Get rid of fixing up pointers on the main thread
- Get rid of sweeping on the main thread

Instead:
- Record (and process afterwards) slots in parallel
- Add the pages to the concurrent sweeper as pointers have already been fixed

This reverts commit 6df04b296b87e1dad7eb4383167553e721e5fbd8.

BUG=chromium:581412
LOG=N
TEST=cctest/test-compaction/*
==========

to

==========
Reland of "[heap] Better integrate handling of aborted compaction pages"

- Get rid of fixing up pointers on the main thread
- Get rid of sweeping on the main thread

Instead:
- Record (and process afterwards) slots in parallel
- Add the pages to the concurrent sweeper as pointers have already been fixed

This reverts commit 6df04b296b87e1dad7eb4383167553e721e5fbd8.

BUG=chromium:581412
LOG=N
TEST=cctest/test-compaction/*
==========

[commit-bot: I haz the power, 2016-04-14 11:06:27]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-14 11:07:23]

Description was changed from

==========
Reland of "[heap] Better integrate handling of aborted compaction pages"

- Get rid of fixing up pointers on the main thread
- Get rid of sweeping on the main thread

Instead:
- Record (and process afterwards) slots in parallel
- Add the pages to the concurrent sweeper as pointers have already been fixed

This reverts commit 6df04b296b87e1dad7eb4383167553e721e5fbd8.

BUG=chromium:581412
LOG=N
TEST=cctest/test-compaction/*
==========

to

==========
Reland of "[heap] Better integrate handling of aborted compaction pages"

- Get rid of fixing up pointers on the main thread
- Get rid of sweeping on the main thread

Instead:
- Record (and process afterwards) slots in parallel
- Add the pages to the concurrent sweeper as pointers have already been fixed

This reverts commit 6df04b296b87e1dad7eb4383167553e721e5fbd8.

BUG=chromium:581412
LOG=N
TEST=cctest/test-compaction/*

Committed: https://crrev.com/3ace01d1b33faed8f67bfa8a7fb04b118caafe3a
Cr-Commit-Position: refs/heads/master@{#35485}
==========

[commit-bot: I haz the power, 2016-04-14 11:07:24]

Patchset 2 (id:??) landed as
https://crrev.com/3ace01d1b33faed8f67bfa8a7fb04b118caafe3a
Cr-Commit-Position: refs/heads/master@{#35485}