Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1891673003: Pass CFX_WideString to CXFA_FFDocView::GetWidgetByName. (Closed)

Created:
4 years, 8 months ago by Tom Sepez
Modified:
4 years, 8 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Pass CFX_WideString to CXFA_FFDocView::GetWidgetByName. Avoids downgrade followed by duplication of existing strings. Committed: https://pdfium.googlesource.com/pdfium/+/70c5520270ab41b71e8ae8d2e888b9ba25383190

Patch Set 1 #

Total comments: 2

Patch Set 2 : Nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -24 lines) Patch
M fpdfsdk/fsdk_baseform.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_ffdocview.cpp View 1 3 chunks +11 lines, -11 lines 0 comments Download
M xfa/fxfa/app/xfa_ffpageview.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/include/xfa_ffdocview.h View 3 chunks +8 lines, -8 lines 0 comments Download
M xfa/fxfa/include/xfa_ffpageview.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Tom Sepez
Lei, next one.
4 years, 8 months ago (2016-04-14 21:50:03 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/1891673003/diff/1/xfa/fxfa/app/xfa_ffdocview.cpp File xfa/fxfa/app/xfa_ffdocview.cpp (right): https://codereview.chromium.org/1891673003/diff/1/xfa/fxfa/app/xfa_ffdocview.cpp#newcode498 xfa/fxfa/app/xfa_ffdocview.cpp:498: if (CXFA_WidgetAcc* pAcc = GetWidgetAccByName(wsName, pRefAcc)) CXFA_WidgetAcc* pAcc ...
4 years, 8 months ago (2016-04-14 22:15:11 UTC) #3
Tom Sepez
https://codereview.chromium.org/1891673003/diff/1/xfa/fxfa/app/xfa_ffdocview.cpp File xfa/fxfa/app/xfa_ffdocview.cpp (right): https://codereview.chromium.org/1891673003/diff/1/xfa/fxfa/app/xfa_ffdocview.cpp#newcode498 xfa/fxfa/app/xfa_ffdocview.cpp:498: if (CXFA_WidgetAcc* pAcc = GetWidgetAccByName(wsName, pRefAcc)) On 2016/04/14 22:15:10, ...
4 years, 8 months ago (2016-04-14 22:19:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1891673003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1891673003/20001
4 years, 8 months ago (2016-04-14 22:20:58 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 22:32:38 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/70c5520270ab41b71e8ae8d2e888b9ba2538...

Powered by Google App Engine
This is Rietveld 408576698