[compiler] Prevent unnecessary parsing with interpreter.

[compiler] Prevent unnecessary parsing with interpreter.

This disables parsing when we optimize directly from bytecode using
TurboFan, because TurboFan is capable of building graphs out of the
bytecode directly.

R=bmeurer@chromium.org
BUG=v8:4280
LOG=n

Committed: https://crrev.com/8a29223c0183ec99cfb8e9f926976774b2b9db26
Cr-Commit-Position: refs/heads/master@{#35567}

[Michael Starzinger, 2016-04-15 12:15:24]

Description was changed from

==========
[compiler] Prevent unnecessary parsing with interpreter.

This disables parsing when we optimized directly from bytecode using
TurboFan, because TurboFan is capable of building graphs out of the
bytecode directly.

R=
BUG=v8:4280
LOG=n
==========

to

==========
[compiler] Prevent unnecessary parsing with interpreter.

This disables parsing when we optimized directly from bytecode using
TurboFan, because TurboFan is capable of building graphs out of the
bytecode directly.

R=bmeurer@chromium.org
BUG=v8:4280
LOG=n
==========

[Michael Starzinger, 2016-04-15 12:15:25]

mstarzinger@chromium.org changed reviewers:
+ bmeurer@chromium.org, rmcilroy@chromium.org

[Michael Starzinger, 2016-04-15 12:21:40]

Benedikt: PTAL.
Ross: FYI.

https://codereview.chromium.org/1891663004/diff/1/src/compiler/pipeline.cc
File src/compiler/pipeline.cc (right):

https://codereview.chromium.org/1891663004/diff/1/src/compiler/pipeline.cc#ne...
src/compiler/pipeline.cc:559: if
(!data->info()->shared_info()->HasBytecodeArray()) {
We could add a flag (i.e. "kOptimizeFromBytecode") on CompilationInfo that tells
us whether we are running in the "Ignition->TF" or the "FullCodegen->TF" mode.
That flag would be checked here, below, and also in the GraphBuilderPhase.
Please advise which you think is better.

[Michael Starzinger, 2016-04-15 12:23:34]

Description was changed from

==========
[compiler] Prevent unnecessary parsing with interpreter.

This disables parsing when we optimized directly from bytecode using
TurboFan, because TurboFan is capable of building graphs out of the
bytecode directly.

R=bmeurer@chromium.org
BUG=v8:4280
LOG=n
==========

to

==========
[compiler] Prevent unnecessary parsing with interpreter.

This disables parsing when we optimize directly from bytecode using
TurboFan, because TurboFan is capable of building graphs out of the
bytecode directly.

R=bmeurer@chromium.org
BUG=v8:4280
LOG=n
==========

[Benedikt Meurer, 2016-04-15 12:38:28]

https://codereview.chromium.org/1891663004/diff/1/src/compiler/pipeline.cc
File src/compiler/pipeline.cc (right):

https://codereview.chromium.org/1891663004/diff/1/src/compiler/pipeline.cc#ne...
src/compiler/pipeline.cc:559: if
(!data->info()->shared_info()->HasBytecodeArray()) {
I'd really prefer the kOptimizeFromBytecode flag.

[rmcilroy, 2016-04-15 13:19:12]

https://codereview.chromium.org/1891663004/diff/1/src/compiler/pipeline.cc
File src/compiler/pipeline.cc (right):

https://codereview.chromium.org/1891663004/diff/1/src/compiler/pipeline.cc#ne...
src/compiler/pipeline.cc:559: if
(!data->info()->shared_info()->HasBytecodeArray()) {
On 2016/04/15 12:38:27, Benedikt Meurer wrote:
> I'd really prefer the kOptimizeFromBytecode flag.

+1

[Michael Starzinger, 2016-04-15 13:21:48]

PTAL. Addressed comments.

https://codereview.chromium.org/1891663004/diff/1/src/compiler/pipeline.cc
File src/compiler/pipeline.cc (right):

https://codereview.chromium.org/1891663004/diff/1/src/compiler/pipeline.cc#ne...
src/compiler/pipeline.cc:559: if
(!data->info()->shared_info()->HasBytecodeArray()) {
On 2016/04/15 12:38:27, Benedikt Meurer wrote:
> I'd really prefer the kOptimizeFromBytecode flag.

Done.

[Benedikt Meurer, 2016-04-15 13:26:26]

LGTM.

[rmcilroy, 2016-04-15 13:33:14]

Nice, LGTM

[Michael Starzinger, 2016-04-15 16:05:27]

Patchset #3 (id:40001) has been deleted

[Michael Starzinger, 2016-04-15 16:33:12]

Patchset #3 (id:60001) has been deleted

[Michael Starzinger, 2016-04-18 09:07:31]

The CQ bit was checked by mstarzinger@chromium.org

[Michael Starzinger, 2016-04-18 09:07:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/1891663004/#ps120001
(title: "Rebased.")

[commit-bot: I haz the power, 2016-04-18 09:07:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1891663004/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1891663004/120001

[commit-bot: I haz the power, 2016-04-18 09:10:04]

Description was changed from

==========
[compiler] Prevent unnecessary parsing with interpreter.

This disables parsing when we optimize directly from bytecode using
TurboFan, because TurboFan is capable of building graphs out of the
bytecode directly.

R=bmeurer@chromium.org
BUG=v8:4280
LOG=n
==========

to

==========
[compiler] Prevent unnecessary parsing with interpreter.

This disables parsing when we optimize directly from bytecode using
TurboFan, because TurboFan is capable of building graphs out of the
bytecode directly.

R=bmeurer@chromium.org
BUG=v8:4280
LOG=n
==========

[commit-bot: I haz the power, 2016-04-18 09:10:06]

Committed patchset #5 (id:120001)

[commit-bot: I haz the power, 2016-04-18 09:11:27]

Description was changed from

==========
[compiler] Prevent unnecessary parsing with interpreter.

This disables parsing when we optimize directly from bytecode using
TurboFan, because TurboFan is capable of building graphs out of the
bytecode directly.

R=bmeurer@chromium.org
BUG=v8:4280
LOG=n
==========

to

==========
[compiler] Prevent unnecessary parsing with interpreter.

This disables parsing when we optimize directly from bytecode using
TurboFan, because TurboFan is capable of building graphs out of the
bytecode directly.

R=bmeurer@chromium.org
BUG=v8:4280
LOG=n

Committed: https://crrev.com/8a29223c0183ec99cfb8e9f926976774b2b9db26
Cr-Commit-Position: refs/heads/master@{#35567}
==========

[commit-bot: I haz the power, 2016-04-18 09:11:27]

Patchset 5 (id:??) landed as
https://crrev.com/8a29223c0183ec99cfb8e9f926976774b2b9db26
Cr-Commit-Position: refs/heads/master@{#35567}