Remove unnecessary calls to AddWakeOnPaketConnection and RemoveWakeOnPacketConnection

chrome/browser/chromeos/net/wake_on_wifi_connection_observer.h

Index: chrome/browser/chromeos/net/wake_on_wifi_connection_observer.h
diff --git a/chrome/browser/chromeos/net/wake_on_wifi_connection_observer.h b/chrome/browser/chromeos/net/wake_on_wifi_connection_observer.h
new file mode 100644
index 0000000000000000000000000000000000000000..d88790d50484211f3e47bd34eb005398ba090f56
--- /dev/null
+++ b/chrome/browser/chromeos/net/wake_on_wifi_connection_observer.h
@@ -0,0 +1,65 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_CHROMEOS_NET_WAKE_ON_WIFI_CONNECTION_OBSERVER_H_
+#define CHROME_BROWSER_CHROMEOS_NET_WAKE_ON_WIFI_CONNECTION_OBSERVER_H_
+
+#include "base/gtest_prod_util.h"
+#include "base/macros.h"
+#include "chrome/browser/chromeos/net/wake_on_wifi_manager.h"
+#include "components/gcm_driver/gcm_connection_observer.h"
+#include "content/public/browser/notification_observer.h"
+#include "net/base/ip_endpoint.h"
+
+class Profile;
+
+namespace chromeos {
+
+class NetworkDeviceHandler;
+
+// Simple class that listens for a connection to the GCM server and passes the
+// connection information down to shill.  Each profile gets its own instance
+// of this class.

[stevenjb, 2016/04/20 20:16:28]

The last sentence doesn't really apply to this class. You could say 'Each
instance of this class is associated with a profile', but that really isn't
necessary, I would just remove the sentence.

[malaykeshav, 2016/04/20 23:14:55]

done

+class WakeOnWifiConnectionObserver : public gcm::GCMConnectionObserver {
+ public:
+  ~WakeOnWifiConnectionObserver() override;
+
+  void HandleWifiDevicePropertiesReady();

[stevenjb, 2016/04/20 20:16:28]

public methods should be documented (except trivial setters/getters)

[malaykeshav, 2016/04/20 23:14:55]

done

+
+  // gcm::GCMConnectionObserver overrides:
+  void OnConnected(const net::IPEndPoint& ip_endpoint) override;
+  void OnDisconnected() override;
+
+  void set_feature(WakeOnWifiManager::WakeOnWifiFeature feature) {
+    feature_ = feature;
+  }
+
+ private:
+  FRIEND_TEST_ALL_PREFIXES(WakeOnWifiObserverTest, TestWakeOnWifiPacketAdd);
+  FRIEND_TEST_ALL_PREFIXES(WakeOnWifiObserverTest,
+                           TestWakeOnWifiPacketRemove);
+  FRIEND_TEST_ALL_PREFIXES(WakeOnWifiObserverTest, TestWakeOnWifiNoneAdd);
+  FRIEND_TEST_ALL_PREFIXES(WakeOnWifiObserverTest, TestWakeOnWifiNoneRemove);
+  friend class WakeOnWifiManager;
+
+  WakeOnWifiConnectionObserver(Profile* profile,
+                               bool wifi_properties_received,
+                               WakeOnWifiManager::WakeOnWifiFeature feature,
+                               NetworkDeviceHandler* network_device_handler);
+
+  void AddWakeOnPacketConnection();
+  void RemoveWakeOnPacketConnection();
+
+  Profile* profile_;
+  net::IPEndPoint ip_endpoint_;
+  bool wifi_properties_received_;
+  WakeOnWifiManager::WakeOnWifiFeature feature_;
+  NetworkDeviceHandler* network_device_handler_;
+
+  DISALLOW_COPY_AND_ASSIGN(WakeOnWifiConnectionObserver);
+};
+
+}  // namespace chromeos
+
+#endif  // CHROME_BROWSER_CHROMEOS_NET_WAKE_ON_WIFI_CONNECTION_OBSERVER_H_