Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1891623003: [Downloads] Set the Referrer header for resumed requests. (Closed)

Created:
4 years, 8 months ago by asanka
Modified:
4 years, 8 months ago
Reviewers:
svaldez, jam
CC:
chromium-reviews, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Downloads] Set the Referrer header for resumed requests. During downloads resumption, the newly created URLRequest was not getting the Referrer header set. Now it is. R=jam@chromium.org,svaldez@chromium.org BUG=603670 Committed: https://crrev.com/f7ae1f45615bc167f2081079557322eefba02c0b Cr-Commit-Position: refs/heads/master@{#389636}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Catch up with ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -39 lines) Patch
M content/browser/download/download_browsertest.cc View 1 2 12 chunks +57 lines, -25 lines 0 comments Download
M content/browser/download/download_item_impl.cc View 3 chunks +11 lines, -4 lines 0 comments Download
M content/public/test/test_download_request_handler.h View 1 2 1 chunk +18 lines, -1 line 0 comments Download
M content/public/test/test_download_request_handler.cc View 1 2 5 chunks +22 lines, -8 lines 0 comments Download
A + content/test/data/download/download-link.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/test/data/download/download-link.html.mock-http-headers View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
asanka
PTAL?
4 years, 8 months ago (2016-04-14 19:45:53 UTC) #1
asanka
On 2016/04/14 at 19:45:53, asanka wrote: > PTAL? jam: content/public/test/* svaldez: content/browser/*, content/test/data/*
4 years, 8 months ago (2016-04-14 19:46:45 UTC) #2
svaldez
lgtm
4 years, 8 months ago (2016-04-15 14:19:08 UTC) #3
jam
lgtm, sorry for delay I missed this
4 years, 8 months ago (2016-04-19 18:27:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1891623003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1891623003/40001
4 years, 8 months ago (2016-04-26 00:26:41 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-26 00:33:23 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 00:35:10 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f7ae1f45615bc167f2081079557322eefba02c0b
Cr-Commit-Position: refs/heads/master@{#389636}

Powered by Google App Engine
This is Rietveld 408576698