Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(809)

Unified Diff: Source/core/page/Performance.h

Issue 18916003: Performance.onwebkitresourcetimingbufferfull should be a Function (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/page/Performance.h
diff --git a/Source/core/page/Performance.h b/Source/core/page/Performance.h
index 161a584bc8a4fa52b65ad058f0e75c10f1803391..ef6aed1f98afb7ba350e4ba4245cc6a0d560d382 100644
--- a/Source/core/page/Performance.h
+++ b/Source/core/page/Performance.h
@@ -32,8 +32,9 @@
#ifndef Performance_h
#define Performance_h
+#include "bindings/v8/ScriptValue.h"
#include "bindings/v8/ScriptWrappable.h"
-#include "core/dom/EventTarget.h"
+#include "core/dom/ExceptionCode.h"
#include "core/page/DOMWindowProperty.h"
#include "core/page/MemoryInfo.h"
#include "core/page/PerformanceEntry.h"
@@ -51,14 +52,11 @@ class ResourceRequest;
class ResourceResponse;
class UserTiming;
-class Performance : public ScriptWrappable, public RefCounted<Performance>, public DOMWindowProperty, public EventTarget {
+class Performance : public ScriptWrappable, public RefCounted<Performance>, public DOMWindowProperty {
public:
static PassRefPtr<Performance> create(Frame* frame) { return adoptRef(new Performance(frame)); }
~Performance();
- virtual const AtomicString& interfaceName() const;
- virtual ScriptExecutionContext* scriptExecutionContext() const;
-
PassRefPtr<MemoryInfo> memory() const;
PerformanceNavigation* navigation() const;
PerformanceTiming* timing() const;
@@ -69,15 +67,13 @@ public:
Vector<RefPtr<PerformanceEntry> > getEntriesByName(const String& name, const String& entryType);
void webkitClearResourceTimings();
- void webkitSetResourceTimingBufferSize(unsigned int);
+ void webkitSetResourceTimingBufferSize(ScriptState*, unsigned);
- DEFINE_ATTRIBUTE_EVENT_LISTENER(webkitresourcetimingbufferfull);
+ const ScriptValue& onwebkitresourcetimingbufferfull() { return m_onwebkitresourcetimingbufferfull; }
+ void setOnwebkitresourcetimingbufferfull(const ScriptValue& callback);
void addResourceTiming(const String& initiatorName, Document*, const ResourceRequest&, const ResourceResponse&, double initiationTime, double finishTime);
- using RefCounted<Performance>::ref;
- using RefCounted<Performance>::deref;
-
void mark(const String& markName, ExceptionCode&);
void clearMarks(const String& markName);
@@ -86,15 +82,10 @@ public:
private:
explicit Performance(Frame*);
+ void callResourceTimingBufferFullCallback(ScriptState*);
- virtual void refEventTarget() { ref(); }
- virtual void derefEventTarget() { deref(); }
- virtual EventTargetData* eventTargetData();
- virtual EventTargetData* ensureEventTargetData();
bool isResourceTimingBufferFull();
- EventTargetData m_eventTargetData;
-
mutable RefPtr<PerformanceNavigation> m_navigation;
mutable RefPtr<PerformanceTiming> m_timing;
@@ -102,6 +93,8 @@ private:
unsigned m_resourceTimingBufferSize;
RefPtr<UserTiming> m_userTiming;
+
+ ScriptValue m_onwebkitresourcetimingbufferfull;
};
}

Powered by Google App Engine
This is Rietveld 408576698