Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 1891583003: Allow xctests to embed themselves in their TEST_HOST for Xcode 7.3 support. (Closed)

Created:
4 years, 8 months ago by justincohen
Modified:
4 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow xctests to embed themselves in their TEST_HOST for Xcode 7.3 support. BUG=603607 Committed: https://crrev.com/07d034d2a7c0312be036904c3e9c4f23f68193c1 Cr-Commit-Position: refs/heads/master@{#387904}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M ios/web/ios_web_shell_tests.gyp View 3 chunks +12 lines, -1 line 1 comment Download

Messages

Total messages: 13 (6 generated)
baxley
https://codereview.chromium.org/1891583003/diff/1/ios/web/ios_web_shell_tests.gyp File ios/web/ios_web_shell_tests.gyp (right): https://codereview.chromium.org/1891583003/diff/1/ios/web/ios_web_shell_tests.gyp#newcode55 ios/web/ios_web_shell_tests.gyp:55: '${BUILT_PRODUCTS_DIR}/ios_web_shell_test.xctest', are there two copies of xctest to make ...
4 years, 8 months ago (2016-04-14 21:48:50 UTC) #3
baxley
nevermind, I get it. LGTM.
4 years, 8 months ago (2016-04-14 21:49:40 UTC) #4
justincohen
Over to rohitrao for discussion.
4 years, 8 months ago (2016-04-14 21:50:34 UTC) #6
rohitrao (ping after 24h)
lgtm
4 years, 8 months ago (2016-04-14 22:15:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1891583003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1891583003/1
4 years, 8 months ago (2016-04-18 14:10:08 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 14:51:11 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 14:52:34 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/07d034d2a7c0312be036904c3e9c4f23f68193c1
Cr-Commit-Position: refs/heads/master@{#387904}

Powered by Google App Engine
This is Rietveld 408576698