Added simple url fixer for blimp toolbar

blimp/client/app/android/toolbar.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "blimp/client/app/android/toolbar.h"
 
 #include "base/android/jni_string.h"
 #include "blimp/client/app/android/blimp_client_session_android.h"
+#include "components/url_formatter/url_fixer.h"
 #include "jni/Toolbar_jni.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "ui/gfx/android/java_bitmap.h"
 #include "url/gurl.h"
 
 namespace blimp {
 namespace client {
 
 namespace {
 
@@ skipping 30 matching lines @@
   navigation_feature_->RemoveDelegate(kDummyTabId);
 }
 
 void Toolbar::Destroy(JNIEnv* env, const JavaParamRef<jobject>& jobj) {
   delete this;
 }
 
 void Toolbar::OnUrlTextEntered(JNIEnv* env,
                                const JavaParamRef<jobject>& jobj,
                                const JavaParamRef<jstring>& text) {
-  navigation_feature_->NavigateToUrlText(
-      kDummyTabId, base::android::ConvertJavaStringToUTF8(env, text));
+  std::string url = base::android::ConvertJavaStringToUTF8(env, text);
+
+  // Build a search query, if |url| doesn't have a '.' anywhere.

[Peter Kasting, 2016/04/14 04:34:01]

This will give you both false positives and false negatives.

Why not use the AutocompleteClassifier instead?  That will do intelligent fixup
and transformation.  You'll basically get something that will act like the
Chrome omnibox would if you entered the text in question and then hit enter to
select the default match.

You can trim down the set of providers you construct the classifier with if
certain bits aren't applicable to you, e.g. the builtins or shortcuts providers.

[shaktisahu, 2016/04/14 17:55:23]

We looked at AutocompleteClassfier before, but it requires to add a lot of
dependency to chrome. Currently in blimp, we don't want to add anything from
chrome and make a very basic version ready. However, later during clank
integration we want to revisit this and make it right.

[Peter Kasting, 2016/04/14 20:38:44]

How long ago did you look?  This has all been componentized in the last months,
and I don't believe you need any dependencies on chrome/ to use this now.

Even if that isn't true, if you plan to do this better at some point, I'd rather
do nothing at all now, and leave this so painfully wrong that it can't possibly
ship this way, than make it marginally better but still not actually good enough
for real use.

[nyquist, 2016/04/15 16:21:55]

I believe the plan would be to merge this with the normal Chrome for Android
toolbar.

[shaktisahu, 2016/04/15 18:32:35]

Actually, this is a temporary work. All this code will go away next month after
it is integrated to chrome and we will use chrome omnibox. The purpose of this
is primarily for the blimp demo since it is very hard to type the full URL every
time.

+  if (url.find(".") == std::string::npos) {

[Peter Kasting, 2016/04/15 18:35:52]

Nit: {} not necessary

[shaktisahu, 2016/04/15 18:59:06]

Done.

+    url = std::string("http://www.google.com/search?q=") + url;

[Peter Kasting, 2016/04/15 18:35:53]

Nit: std::string() not necessary

[shaktisahu, 2016/04/15 18:59:06]

Done.

+  }
+  GURL fixedUrl = url_formatter::FixupURL(url, std::string());

[Peter Kasting, 2016/04/15 18:35:52]

Nit: fixed_url

[shaktisahu, 2016/04/15 18:59:06]

Done.

+  navigation_feature_->NavigateToUrlText(kDummyTabId, fixedUrl.spec());
 }
 
 void Toolbar::OnReloadPressed(JNIEnv* env, const JavaParamRef<jobject>& jobj) {
   navigation_feature_->Reload(kDummyTabId);
 }
 
 void Toolbar::OnForwardPressed(JNIEnv* env, const JavaParamRef<jobject>& jobj) {
   navigation_feature_->GoForward(kDummyTabId);
 }
 
@@ skipping 41 matching lines @@
   JNIEnv* env = base::android::AttachCurrentThread();
 
   Java_Toolbar_onEngineSentPageLoadStatusUpdate(
       env,
       java_obj_.obj(),
       static_cast<jboolean>(completed));
 }
 
 }  // namespace client
 }  // namespace blimp