|
|
Chromium Code Reviews|
Created:
4 years, 8 months ago by manzagop (departed) Modified:
4 years, 8 months ago CC:
chromium-reviews, Sigurður Ásgeirsson Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionTemporarily enable hang report capture.
Overview:
Browser process hangs are believed to be responsible for a large
fraction of browser unclean shutdowns on Windows. This patch enables
hang report capture to get visibility into the problem.
Note:
- Capture only occurs on canary Chrome for users with stats consent.
- The plan is to release for a single day.
BUG=478209
Committed: https://crrev.com/738c706910c84318db6f5309a1ff4c3584338722
Cr-Commit-Position: refs/heads/master@{#387473}
Patch Set 1 #Patch Set 2 : Make GN consistent with GYP #Patch Set 3 : Fix GN logic #Patch Set 4 : Missing GN include #
Messages
Total messages: 30 (14 generated)
Description was changed from ========== Temporarily enable hang report capture. Temporarily enable hang report capture. Overview: Browser process hangs are believed to be responsible for a large fraction of browser unclean shutdowns on Windows. This patch enables hang report capture to get visibility into the problem. Note: - Capture only occurs on canary Chrome for users with stats consent. - The plan is to release for a single day. BUG=478209 ========== to ========== Temporarily enable hang report capture. Overview: Browser process hangs are believed to be responsible for a large fraction of browser unclean shutdowns on Windows. This patch enables hang report capture to get visibility into the problem. Note: - Capture only occurs on canary Chrome for users with stats consent. - The plan is to release for a single day. BUG=478209 ==========
manzagop@chromium.org changed reviewers: + jochen@chromium.org, pmonette@chromium.org
Hi! - This is to temporarily enable hang instrumentation. - I'm looking for a correctness (pmonette) and owner's (jochen) approval. Thanks! Pierre
lgtm
why no corresponding gn change?
Patchset #2 (id:20001) has been deleted
On 2016/04/14 13:30:47, jochen - slow wrote: > why no corresponding gn change? Thank you for catching that. Having inconsistent gyp/gn is a bad idea. Fixed. Please have another look!
lgtm
Thanks! Submitting.
The CQ bit was checked by manzagop@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from pmonette@chromium.org, jochen@chromium.org Link to the patchset: https://codereview.chromium.org/1891563002/#ps60001 (title: "Fix GN logic")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1891563002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1891563002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_clang on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
The CQ bit was checked by manzagop@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from pmonette@chromium.org, jochen@chromium.org Link to the patchset: https://codereview.chromium.org/1891563002/#ps80001 (title: "Missing GN include")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1891563002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1891563002/80001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by manzagop@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1891563002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1891563002/80001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by pmonette@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1891563002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1891563002/80001
Message was sent while issue was closed.
Description was changed from ========== Temporarily enable hang report capture. Overview: Browser process hangs are believed to be responsible for a large fraction of browser unclean shutdowns on Windows. This patch enables hang report capture to get visibility into the problem. Note: - Capture only occurs on canary Chrome for users with stats consent. - The plan is to release for a single day. BUG=478209 ========== to ========== Temporarily enable hang report capture. Overview: Browser process hangs are believed to be responsible for a large fraction of browser unclean shutdowns on Windows. This patch enables hang report capture to get visibility into the problem. Note: - Capture only occurs on canary Chrome for users with stats consent. - The plan is to release for a single day. BUG=478209 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== Temporarily enable hang report capture. Overview: Browser process hangs are believed to be responsible for a large fraction of browser unclean shutdowns on Windows. This patch enables hang report capture to get visibility into the problem. Note: - Capture only occurs on canary Chrome for users with stats consent. - The plan is to release for a single day. BUG=478209 ========== to ========== Temporarily enable hang report capture. Overview: Browser process hangs are believed to be responsible for a large fraction of browser unclean shutdowns on Windows. This patch enables hang report capture to get visibility into the problem. Note: - Capture only occurs on canary Chrome for users with stats consent. - The plan is to release for a single day. BUG=478209 Committed: https://crrev.com/738c706910c84318db6f5309a1ff4c3584338722 Cr-Commit-Position: refs/heads/master@{#387473} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/738c706910c84318db6f5309a1ff4c3584338722 Cr-Commit-Position: refs/heads/master@{#387473}
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:80001) has been created in https://chromiumcodereview.appspot.com/1892843002/ by manzagop@chromium.org. The reason for reverting is: Single day experiment is complete.. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
