Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 1891543005: Remove the generics from _FrozenElementList: causes checked mode failures (Closed)

Created:
4 years, 8 months ago by Alan Knight
Modified:
4 years, 8 months ago
Reviewers:
Jacob
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove the generics from _FrozenElementList: causes checked mode failures BUG= R=jacobr@google.com Committed: https://github.com/dart-lang/sdk/commit/7824ac771b349fcdd07b687d2c3f33fe2ba7cfaa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Alan Knight
Not having them causes strong mode failures, but having them causes checked mode failures. Proper ...
4 years, 8 months ago (2016-04-14 20:31:04 UTC) #2
Jacob
lgtm
4 years, 8 months ago (2016-04-14 22:05:03 UTC) #3
Alan Knight
4 years, 8 months ago (2016-04-14 22:14:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7824ac771b349fcdd07b687d2c3f33fe2ba7cfaa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698