Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2579)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/trace_event/heap_profiler_allocation_register_unittest.cc

Issue 1891543003: [tracing] Turn StackFrame into struct. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/trace_event/heap_profiler_allocation_context_tracker.cc ('K') | « base/trace_event/heap_profiler_allocation_context_tracker_unittest.cc ('k') | base/trace_event/heap_profiler_heap_dump_writer.cc » ('j') | base/trace_event/heap_profiler_heap_dump_writer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/trace_event/heap_profiler_allocation_register_unittest.cc
diff --git a/base/trace_event/heap_profiler_allocation_register_unittest.cc b/base/trace_event/heap_profiler_allocation_register_unittest.cc
index ceaff6e062fecf3165828350a7a415d11caf30a3..2d5129bc8a13a05bcde6c242b3f85dba48f56407 100644
--- a/base/trace_event/heap_profiler_allocation_register_unittest.cc
+++ b/base/trace_event/heap_profiler_allocation_register_unittest.cc
@@ -107,8 +107,10 @@ TEST_F(AllocationRegisterTest, DoubleInsertOverwrites) {
// Find out the cause and ban double insert if possible.
AllocationRegister reg;
AllocationContext ctx = AllocationContext::Empty();
- StackFrame frame1 = "Foo";
- StackFrame frame2 = "Bar";
+ StackFrame frame1 = StackFrame::FromTraceEventName("Foo");
+ StackFrame frame2 = StackFrame::FromTraceEventName("Bar");
+
+ ctx.backtrace.frame_count = 1;
ctx.backtrace.frames[0] = frame1;
reg.Insert(reinterpret_cast<void*>(1), 11, ctx);
« base/trace_event/heap_profiler_allocation_context_tracker.cc ('K') | « base/trace_event/heap_profiler_allocation_context_tracker_unittest.cc ('k') | base/trace_event/heap_profiler_heap_dump_writer.cc » ('j') | base/trace_event/heap_profiler_heap_dump_writer.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698