Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: tests/lib/async/stream_controller_async_test.dart

Issue 18915008: Let StreamSubscription.cancel return a Future. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Mark failing tests. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/async/stream_pipe.dart ('k') | tests/lib/async/stream_state_nonzero_timer_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/lib/async/stream_controller_async_test.dart
diff --git a/tests/lib/async/stream_controller_async_test.dart b/tests/lib/async/stream_controller_async_test.dart
index 22226ddacada0b9c9c82fffbf44b743197e3b61d..d66a6f164702fff2b4164b360fddfa7deb951e6d 100644
--- a/tests/lib/async/stream_controller_async_test.dart
+++ b/tests/lib/async/stream_controller_async_test.dart
@@ -279,8 +279,8 @@ testPause() {
})
..expectData(43)
..expectData(44)
- ..expectDone()
- ..expectCancel(test.terminate);
+ ..expectCancel()
+ ..expectDone(test.terminate);
test.listen();
test.add(42);
test.add(43);
@@ -303,8 +303,8 @@ testPause() {
})
..expectData(43)
..expectData(44)
- ..expectDone()
- ..expectCancel(test.terminate);
+ ..expectCancel()
+ ..expectDone(test.terminate);
test..listen()
..add(42)
..add(43)
@@ -325,8 +325,8 @@ testPause() {
})
..expectData(43)
..expectData(44)
- ..expectDone()
- ..expectCancel(test.terminate);
+ ..expectCancel()
+ ..expectDone(test.terminate);
test..listen()
..add(42)
..add(43)
@@ -351,8 +351,8 @@ testPause() {
})
..expectData(43)
..expectData(44)
- ..expectDone()
- ..expectCancel(test.terminate);
+ ..expectCancel()
+ ..expectDone(test.terminate);
test..listen()
..add(42);
});
@@ -417,8 +417,8 @@ void testBroadcastController() {
StreamProtocolTest test = new StreamProtocolTest.broadcast();
test..expectListen()
..expectData(42)
- ..expectDone()
- ..expectCancel(test.terminate);
+ ..expectCancel()
+ ..expectDone(test.terminate);
test..listen()
..add(42)
..close();
@@ -436,8 +436,8 @@ void testBroadcastController() {
..expectData(37)
..expectData(37)
..expectDone()
- ..expectDone()
- ..expectCancel(test.terminate);
+ ..expectCancel()
+ ..expectDone(test.terminate);
test.listen();
test.add(42);
});
@@ -459,8 +459,8 @@ void testBroadcastController() {
..expectData(37, () {
test.close();
})
- ..expectDone()
- ..expectCancel(test.terminate);
+ ..expectCancel()
+ ..expectDone(test.terminate);
test.listen();
});
@@ -560,9 +560,9 @@ void testAsBroadcast() {
..expectResume(() {
test.close();
})
+ ..expectCancel()
..expectDone()
- ..expectBroadcastCancel()
- ..expectCancel(test.terminate);
+ ..expectBroadcastCancel((_) => test.terminate());
sub = test.listen();
});
}
« no previous file with comments | « sdk/lib/async/stream_pipe.dart ('k') | tests/lib/async/stream_state_nonzero_timer_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698