Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1891483005: [ios] Added API to enable/disable web usage for WebState. (Closed)

Created:
4 years, 8 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Added API to enable/disable web usage for WebState. Updated web// code to use WebState API instead of Web Controller. Also corrected order of methods in TestWebState BUG=597997 Committed: https://crrev.com/4fd05e4e74d72daa024d6a5ac8210bb018aa17b7 Cr-Commit-Position: refs/heads/master@{#388354}

Patch Set 1 #

Patch Set 2 : Self review #

Patch Set 3 : Merged with origin/master #

Patch Set 4 : Self review #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -13 lines) Patch
M ios/web/public/test/test_web_state.h View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M ios/web/public/test/test_web_state.mm View 1 2 2 chunks +15 lines, -5 lines 0 comments Download
M ios/web/public/web_state/web_state.h View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M ios/web/shell/DEPS View 1 2 1 chunk +0 lines, -1 line 1 comment Download
M ios/web/shell/view_controller.mm View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M ios/web/test/web_test.mm View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller_unittest.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/web_state_impl.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M ios/web/web_state/web_state_impl.mm View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M ios/web/web_state/web_state_impl_unittest.mm View 1 2 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1891483005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1891483005/1
4 years, 8 months ago (2016-04-15 02:58:42 UTC) #2
Eugene But (OOO till 7-30)
4 years, 8 months ago (2016-04-15 02:58:50 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-15 03:39:20 UTC) #6
rohitrao (ping after 24h)
lgtm
4 years, 8 months ago (2016-04-19 11:31:55 UTC) #7
kkhorimoto
lgtm https://codereview.chromium.org/1891483005/diff/60001/ios/web/shell/DEPS File ios/web/shell/DEPS (left): https://codereview.chromium.org/1891483005/diff/60001/ios/web/shell/DEPS#oldcode9 ios/web/shell/DEPS:9: "+ios/web/web_state/ui/crw_web_controller.h", yay :)
4 years, 8 months ago (2016-04-19 22:49:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1891483005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1891483005/60001
4 years, 8 months ago (2016-04-19 22:51:47 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-19 23:30:39 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:18:00 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/4fd05e4e74d72daa024d6a5ac8210bb018aa17b7
Cr-Commit-Position: refs/heads/master@{#388354}

Powered by Google App Engine
This is Rietveld 408576698