third_party/WebKit/Source/web/WebViewImpl.h - Issue 1891473002: WTF: Implement explicit RefPtr::operator bool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.h

Issue 1891473002: WTF: Implement explicit RefPtr::operator bool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebViewImpl.h

diff --git a/third_party/WebKit/Source/web/WebViewImpl.h b/third_party/WebKit/Source/web/WebViewImpl.h

index 7f1d23c77c98a2df04b62ade354ff12184ef1f4f..6f6f48df542d904a65214e279894e184c284886b 100644

--- a/third_party/WebKit/Source/web/WebViewImpl.h

+++ b/third_party/WebKit/Source/web/WebViewImpl.h

@@ -435,7 +435,7 @@ public:

WebViewScheduler* scheduler() const override;

void setVisibilityState(WebPageVisibilityState, bool) override;

- bool hasOpenedPopup() const { return m_pagePopup; }

+ bool hasOpenedPopup() const { return m_pagePopup.get(); }

// Returns true if the event leads to scrolling.

static bool mapKeyCodeForScroll(