Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 1891453002: Don't try to render composited selection in throttled frame (Closed)

Created:
4 years, 8 months ago by Sami
Modified:
4 years, 8 months ago
Reviewers:
pdr., Xianzhu
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't try to render composited selection in throttled frame If a frame is throttled (i.e., offscreen) and has focus, we should not try to render a composited selection for it because its layout information might be out of date. BUG=602334 Committed: https://crrev.com/c8d969a6d0378200d361d49ebe2b89c9449d9928 Cr-Commit-Position: refs/heads/master@{#387047}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -0 lines) Patch
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp View 2 chunks +38 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/sim/SimCompositor.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/sim/SimCompositor.cpp View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Sami
PTAL.
4 years, 8 months ago (2016-04-13 17:32:45 UTC) #3
Xianzhu
lgtm. Also +pdr for Source/web.
4 years, 8 months ago (2016-04-13 17:37:06 UTC) #5
pdr.
On 2016/04/13 at 17:37:06, wangxianzhu wrote: > lgtm. > > Also +pdr for Source/web. LGTM
4 years, 8 months ago (2016-04-13 18:02:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1891453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1891453002/1
4 years, 8 months ago (2016-04-13 18:06:08 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-13 18:46:27 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 18:47:44 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c8d969a6d0378200d361d49ebe2b89c9449d9928
Cr-Commit-Position: refs/heads/master@{#387047}

Powered by Google App Engine
This is Rietveld 408576698