Issue 189143006: MIPS: Symbols for type cells.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 189143006: MIPS: Symbols for type cells. (Closed)

Created:
6 years, 9 months ago by kilvadyb

Modified:
6 years, 9 months ago

Reviewers:
Paul Lind, danno, kisg, mvstanton, palfia, dusmil

CC:
v8-dev

Base URL:
https://github.com/v8/v8.git@gbl

Visibility:
Public.

More Reviews

Description

MIPS: Symbols for type cells. Port r19706 (81fd8dd) Original commit message: We can make more efficient code to check against type cells in the future if we use symbols, guaranteed not to conflict with user code. Currently, the "symbols" are the hole and undefined. Undefined may come in from the outside. BUG=

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -22 lines)			Patch
M	src/mips/builtins-mips.cc	View	2 chunks	+6 lines, -7 lines	0 comments	Download
M	src/mips/code-stubs-mips.cc	View	7 chunks	+18 lines, -12 lines	0 comments	Download
M	src/mips/lithium-codegen-mips.cc	View	2 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Committed as r19726.  (thx for review Michael)

Expand Messages | Collapse Messages