Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1891423003:
TabManagerDelegator: Disable kernel lowmemorykiller if memory management is handled by Chrome. (Closed)
|
Created:
4 years, 8 months ago by cylee1 Modified:
4 years, 8 months ago Reviewers:
Greg K, Luis Héctor Chávez, Georges Khalil, rickyz (no longer on Chrome), cylee, mdempsky CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionTabManagerDelegator: Disable kernel lowmemorykiller if memory management is handled by Chrome.
BUG=b:24572007
Committed: https://crrev.com/59b734afdc2462062913852a9cb32f4bf24bd81d
Cr-Commit-Position: refs/heads/master@{#388565}
Patch Set 1 #
Total comments: 3
Messages
Total messages: 27 (10 generated)
cylee@chromium.org changed reviewers: + lhchavez@chromium.org
lhchavez@chromium.org changed reviewers: + mdempsky@chromium.org
lgtm +mdempsky for the .mojom file.
https://codereview.chromium.org/1891423003/diff/1/components/arc/common/proce... File components/arc/common/process.mojom (right): https://codereview.chromium.org/1891423003/diff/1/components/arc/common/proce... components/arc/common/process.mojom:107: DisableLowMemoryKiller(); Shouldn't this CL also include an implementation of this method?
https://codereview.chromium.org/1891423003/diff/1/components/arc/common/proce... File components/arc/common/process.mojom (right): https://codereview.chromium.org/1891423003/diff/1/components/arc/common/proce... components/arc/common/process.mojom:107: DisableLowMemoryKiller(); On 2016/04/16 01:33:27, mdempsky wrote: > Shouldn't this CL also include an implementation of this method? This is a mojo interface definition file. The implementation is auto-generated by mojo framework.
ping mdempsky, Any comment? If no I'll send it out later.
The CQ bit was checked by cylee@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1891423003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1891423003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
cylee@chromium.org changed reviewers: + georgesak@chromium.org
Hi Georges, A tiny CL for you. (how come I forget to add you as a reviewer). Thanks !
https://codereview.chromium.org/1891423003/diff/1/components/arc/common/proce... File components/arc/common/process.mojom (right): https://codereview.chromium.org/1891423003/diff/1/components/arc/common/proce... components/arc/common/process.mojom:107: DisableLowMemoryKiller(); On 2016/04/18 09:34:35, cylee1 wrote: > On 2016/04/16 01:33:27, mdempsky wrote: > > Shouldn't this CL also include an implementation of this method? > > This is a mojo interface definition file. The implementation is auto-generated > by mojo framework. For future reviews: All methods in components/arc/common/ that are defined in an *Instance interface do not have an implementation in Chrome-side, only the ones defined in *Host. ARC-side is the opposite.
lgtm
The CQ bit was checked by cylee@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1891423003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1891423003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
cylee@google.com changed reviewers: + cylee@google.com, kerrnel@chromium.org, rickyz@chromium.org
+kerrnel, rickyz for OWNERS review
lgtm
The CQ bit was checked by cylee@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1891423003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1891423003/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== TabManagerDelegator: Disable kernel lowmemorykiller if memory management is handled by Chrome. BUG=b:24572007 ========== to ========== TabManagerDelegator: Disable kernel lowmemorykiller if memory management is handled by Chrome. BUG=b:24572007 Committed: https://crrev.com/59b734afdc2462062913852a9cb32f4bf24bd81d Cr-Commit-Position: refs/heads/master@{#388565} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/59b734afdc2462062913852a9cb32f4bf24bd81d Cr-Commit-Position: refs/heads/master@{#388565} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
