runtime/vm/constant_propagator.cc - Issue 1891353003: Canonicalize TestCidsInstr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/constant_propagator.cc

Issue 1891353003: Canonicalize TestCidsInstr (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/constant_propagator.cc

diff --git a/runtime/vm/constant_propagator.cc b/runtime/vm/constant_propagator.cc

index b8e7c2a014b43ec2cbdcafdc657cb151f82b5579..0b8d6178cf92f0cc389ed3ec59f68cdc7cf66c78 100644

--- a/runtime/vm/constant_propagator.cc

+++ b/runtime/vm/constant_propagator.cc

@@ -533,6 +533,7 @@ void ConstantPropagator::VisitTestSmi(TestSmiInstr* instr) {

void ConstantPropagator::VisitTestCids(TestCidsInstr* instr) {

+ // TODO(sra): Constant fold test.

SetValue(instr, non_constant_);

}

« no previous file with comments | « no previous file | runtime/vm/intermediate_language.h » ('j') | no next file with comments »