Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1891283002: Moves WmTypes to ash/wm/common (Closed)

Created:
4 years, 8 months ago by sky
Modified:
4 years, 8 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moves WmTypes to ash/wm/common BUG=603369 TEST=none R=oshima@chromium.org TBR=oshima@chromium.org Committed: https://crrev.com/8ea9033b5df6d83eca85760ef5c284156d13b48b Cr-Commit-Position: refs/heads/master@{#387641}

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -129 lines) Patch
M ash/ash.gyp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/common/wm_event.h View 1 1 chunk +1 line, -1 line 0 comments Download
A + ash/wm/common/wm_types.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/wm/common/wm_types.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/drag_details.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/lock_layout_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/toplevel_window_event_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_state.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_state_observer.h View 1 chunk +1 line, -1 line 0 comments Download
D ash/wm/wm_types.h View 1 1 chunk +0 lines, -60 lines 0 comments Download
D ash/wm/wm_types.cc View 1 chunk +0 lines, -54 lines 0 comments Download
M ash/wm/workspace/workspace_layout_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_layout_manager_backdrop_delegate.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
sky
4 years, 8 months ago (2016-04-15 17:12:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1891283002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1891283002/20001
4 years, 8 months ago (2016-04-15 17:12:37 UTC) #3
oshima
lgtm
4 years, 8 months ago (2016-04-15 17:21:08 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-15 18:03:31 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 18:05:29 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/8ea9033b5df6d83eca85760ef5c284156d13b48b
Cr-Commit-Position: refs/heads/master@{#387641}

Powered by Google App Engine
This is Rietveld 408576698