Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1350)

Issue 1891273005: Clear settings in Physical Web test setup (Closed)

Created:
4 years, 8 months ago by cco3
Modified:
4 years, 8 months ago
Reviewers:
nyquist, Yaron, mattreynolds
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clear settings in Physical Web test setup Some of the Physical Web tests have broken while we weren't looking. First, the preferences are not being reset in setup. Second, a race condition has been introduced into one test, so we need to sleep appropriately. BUG=596708 Committed: https://crrev.com/3b45c71553394235e1fac316479461b59b2d00dd Cr-Commit-Position: refs/heads/master@{#387979}

Patch Set 1 #

Patch Set 2 : Use CriteriaHelper #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivityTest.java View 1 5 chunks +18 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/UrlManagerTest.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
cco3
4 years, 8 months ago (2016-04-15 21:45:29 UTC) #2
mattreynolds
lgtm
4 years, 8 months ago (2016-04-15 21:57:39 UTC) #3
cco3
4 years, 8 months ago (2016-04-15 21:58:06 UTC) #5
Yaron
lgtm Although if they were failing why aren't they marked disabled? are they not on ...
4 years, 8 months ago (2016-04-18 18:25:08 UTC) #8
Yaron
err are they not on main waterfall?
4 years, 8 months ago (2016-04-18 18:25:17 UTC) #9
cco3
On 2016/04/18 18:25:17, Yaron wrote: > err are they not on main waterfall? I don't ...
4 years, 8 months ago (2016-04-18 18:26:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1891273005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1891273005/20001
4 years, 8 months ago (2016-04-18 18:26:44 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-18 19:12:41 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 19:14:07 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3b45c71553394235e1fac316479461b59b2d00dd
Cr-Commit-Position: refs/heads/master@{#387979}

Powered by Google App Engine
This is Rietveld 408576698