Define the ExtensionId typedef, and use it in extension.h.

Define the ExtensionId typedef, and use it in extension.h.

This is primarily for documentation now, but one could imagine using a more
efficient representation for this known-length string once everywhere is
converted to use the same type name.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255563

[Jeffrey Yasskin, 2014-03-06 23:23:44]

This name is used in a bunch of places already, which this CL doesn't attempt to
clean up yet.

https://code.google.com/p/chromium/codesearch/#search/&sq=package:chromium&q=...

[asargent_no_longer_on_chrome, 2014-03-06 23:32:08]

Cool, lgtm. 

As you begin to start using this, keep your eye out for whether many places
would only need the ExtensionId definition and don't need the rest of
extension.h, in which case we could move it into it's own header file and help
out compile times.

[Yoyo Zhou, 2014-03-06 23:33:15]

LGTM

[Jeffrey Yasskin, 2014-03-06 23:34:32]

On 2014/03/06 23:32:08, Antony Sargent wrote:
> Cool, lgtm. 
> 
> As you begin to start using this, keep your eye out for whether many places
> would only need the ExtensionId definition and don't need the rest of
> extension.h, in which case we could move it into it's own header file and help
> out compile times.

Good point. Want me to pull it out now or add a comment to that effect?

[asargent_no_longer_on_chrome, 2014-03-07 00:44:45]

On 2014/03/06 23:34:32, Jeffrey Yasskin wrote:
> On 2014/03/06 23:32:08, Antony Sargent wrote:
> > Cool, lgtm. 
> > 
> > As you begin to start using this, keep your eye out for whether many places
> > would only need the ExtensionId definition and don't need the rest of
> > extension.h, in which case we could move it into it's own header file and
help
> > out compile times.
> 
> Good point. Want me to pull it out now or add a comment to that effect?

I think just a comment is fine for now, since it's not clear if it would be a
win or not.

[Jeffrey Yasskin, 2014-03-07 00:52:14]

The CQ bit was checked by jyasskin@chromium.org

[Jeffrey Yasskin, 2014-03-07 00:52:25]

On 2014/03/07 00:44:45, Antony Sargent wrote:
> On 2014/03/06 23:34:32, Jeffrey Yasskin wrote:
> > On 2014/03/06 23:32:08, Antony Sargent wrote:
> > > Cool, lgtm. 
> > > 
> > > As you begin to start using this, keep your eye out for whether many
places
> > > would only need the ExtensionId definition and don't need the rest of
> > > extension.h, in which case we could move it into it's own header file and
> help
> > > out compile times.
> > 
> > Good point. Want me to pull it out now or add a comment to that effect?
> 
> I think just a comment is fine for now, since it's not clear if it would be a
> win or not.

Done, thanks.

[commit-bot: I haz the power, 2014-03-07 01:01:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jyasskin@chromium.org/189123005/20001

[commit-bot: I haz the power, 2014-03-07 09:15:22]

Change committed as 255563