Remove deprecated media switches.

media/filters/vpx_video_decoder.cc

Index: media/filters/vpx_video_decoder.cc
diff --git a/media/filters/vpx_video_decoder.cc b/media/filters/vpx_video_decoder.cc
index b20d891b198930df50737700d8d5d2bb3350e0ae..03f82a311e42c10c51ad62ba0264bd65b4d977ae 100644
--- a/media/filters/vpx_video_decoder.cc
+++ b/media/filters/vpx_video_decoder.cc
@@ -259,16 +259,11 @@ static vpx_codec_ctx* InitializeVpxContext(vpx_codec_ctx* context,
 }
 
 bool VpxVideoDecoder::ConfigureDecoder(const VideoDecoderConfig& config) {
-  const CommandLine* cmd_line = CommandLine::ForCurrentProcess();
-  bool can_handle = false;
-  if (config.codec() == kCodecVP9)
-    can_handle = true;
-  if (!cmd_line->HasSwitch(switches::kDisableVp8AlphaPlayback) &&
-      config.codec() == kCodecVP8 && config.format() == VideoFrame::YV12A) {
-    can_handle = true;
-  }
-  if (!can_handle)
+  if (config.codec() == kCodecVP8 && config.format() != VideoFrame::YV12A) {

[ddorwin, 2014/03/06 21:57:17]

It appears the old code would not support VP8 entirely if disable-vp8-alpha was
specified. Am I reading that right? Is that because non-alpha VP8 goes through
FFmpeg? This could probably use a comment.

[vignesh, 2014/03/06 22:06:53]

the current check is wrong. this will always reject VP8 Alpha because of the
second else if.

the following could be easier to follow.
if (config.codec() != kCodecVP8 && config.codec() != kCodecVP9)
  return false;
// Only VP8 videos with alpha goes through this decoder. Everything else goes
through ffmpeg.
if (config.codec() == kCodecVP8 && config.format() != VideoFrame::YV12A)
  return false;

The pipeline integration tests wouldn't have caught this because the ffmpeg
decoder still won't say no to VP8 videos with alpha, it will decode them
ignoring the alpha channel, so the pipeline won't see any errors.

[DaleCurtis, 2014/03/06 22:13:24]

Whoops, fixed.

     return false;
+  } else if (config.codec() != kCodecVP9) {
+    return false;
+  }
 
   CloseDecoder();