Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1163)

Issue 1891223002: PlzNavigate: fix RFHM test SameOriginFramesInDifferentProcesses (Closed)

Created:
4 years, 8 months ago by clamy
Modified:
4 years, 8 months ago
Reviewers:
nasko, dcheng
CC:
chromium-reviews, carlosk, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PlzNavigate: fix RFHM test SameOriginFramesInDifferentProcesses This Cl fixes RenderFrameHostManagerTest.SameOriginFramesInDifferentProcesses when PlzNavigate is enabled. With PlzNavigate enabled, even if site-per-process is not enabled, the frame in the test will end up in the same process. This is because we chose the SiteInstance for the navigation after it has redirected back to the same url as the current SiteInstance. BUG=475027 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/013326065eb9cb09dd340ec000af673fa17833d1 Cr-Commit-Position: refs/heads/master@{#389454}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M content/browser/frame_host/render_frame_host_manager_browsertest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M testing/buildbot/filters/browser-side-navigation.linux.content_browsertests.filter View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
clamy
@nasko: PTAL
4 years, 8 months ago (2016-04-15 12:08:07 UTC) #4
nasko
Adding dcheng@ as FYI, since he just introduced this test. LGTM
4 years, 8 months ago (2016-04-15 14:50:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1891223002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1891223002/20001
4 years, 8 months ago (2016-04-25 11:06:35 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-25 12:24:33 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 12:26:31 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/013326065eb9cb09dd340ec000af673fa17833d1
Cr-Commit-Position: refs/heads/master@{#389454}

Powered by Google App Engine
This is Rietveld 408576698