Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 1891193003: Fix serialization of forwarding constructors. (Closed)

Created:
4 years, 8 months ago by Johnni Winther
Modified:
4 years, 8 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : dartfmt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -49 lines) Patch
M pkg/compiler/lib/src/serialization/element_serialization.dart View 4 chunks +25 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/serialization/modelz.dart View 1 3 chunks +20 lines, -20 lines 0 comments Download
M tests/compiler/dart2js/serialization_helper.dart View 1 chunk +3 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/serialization_impact_test.dart View 2 chunks +13 lines, -9 lines 0 comments Download
M tests/compiler/dart2js/serialization_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/compiler/dart2js/serialization_test_helper.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
4 years, 8 months ago (2016-04-18 07:13:01 UTC) #2
Siggi Cherem (dart-lang)
lgtm
4 years, 8 months ago (2016-04-18 16:39:11 UTC) #3
Johnni Winther
4 years, 8 months ago (2016-04-19 08:09:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
553eec6047ce7c8add3379efc2083a844a9c1a43 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698