Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 189113009: Linux sandbox: open /proc with O_CLOEXEC (Closed)

Created:
6 years, 9 months ago by jln (very slow on Chromium)
Modified:
6 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jln+watch_chromium.org
Visibility:
Public.

Description

Linux sandbox: open /proc with O_CLOEXEC Prevent one risk of a /proc descriptor leaking by using O_CLOEXEC. BUG=350145 R=jorgelo@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255707

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/common/sandbox_linux/sandbox_linux.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
jln (very slow on Chromium)
Jorge, do you mind approving this tiny CL?
6 years, 9 months ago (2014-03-07 22:01:36 UTC) #1
Jorge Lucangeli Obes
lgtm
6 years, 9 months ago (2014-03-07 22:03:51 UTC) #2
jln (very slow on Chromium)
6 years, 9 months ago (2014-03-07 22:15:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r255707 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698