Issue 189113006: Move ashmem utility functions to discardable_memory_allocator_android.cc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 189113006: Move ashmem utility functions to discardable_memory_allocator_android.cc. (Closed)

Created:
6 years, 9 months ago by Philippe

Modified:
6 years, 9 months ago

Reviewers:
pasko

CC:
chromium-reviews, erikwright+watch_chromium.org, gavinp+memory_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Move ashmem utility functions to discardable_memory_allocator_android.cc. These utility functions are now only used in discardable_memory_allocator_android.cc so they have no reason anymore to live in discardable_memory_android.cc. TBR=willchan@chromium.org BUG=347919 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255638

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+74 lines, -117 lines)			Patch
M	base/base.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	base/memory/discardable_memory_allocator_android.cc	View	6 chunks	+73 lines, -8 lines	0 comments	Download
D	base/memory/discardable_memory_android.h	View	1 chunk	+0 lines, -35 lines	0 comments	Download
M	base/memory/discardable_memory_android.cc	View	2 chunks	+1 line, -73 lines	0 comments	Download

Total messages: 6 (0 generated)

pasko

lgtm, less headers seems good. I did not verify that moving did not change anything ...

6 years, 9 months ago (2014-03-07 13:15:19 UTC) #2

Philippe

Thanks Egor! Yes, this is literally a trivial move, no code change in the functions' ...

6 years, 9 months ago (2014-03-07 13:43:22 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pliard@chromium.org/189113006/1

6 years, 9 months ago (2014-03-07 13:44:14 UTC) #5

Message was sent while issue was closed.

Change committed as 255638