[DevTools] Bring back InspectorInstrumenetation::didHandleEvent

[DevTools] Bring back InspectorInstrumenetation::didHandleEvent

We should clear scheduled pause if event listener doesn't execute JavaScript or setTimeout expression contains syntax error otherwise JS execution will be paused in random place.

R=dgozman@chromium.org,pfeldman@chromium.org
BUG=603792
Committed: https://crrev.com/3f447ebc494e1c3c0296689ca978831044fef623
Cr-Commit-Position: refs/heads/master@{#387660}

[kozy, 2016-04-15 01:00:31]

Description was changed from

==========
[DevTools] Bring back InspectorInstrumenetation::didHandleEvent

We have to clear scheduled pause if event listener doesn't execute JavaScript
otherwise JS execution will be paused in random place.

R=dgozman@chromium.org,pfeldman@chromium.org
==========

to

==========
[DevTools] Bring back InspectorInstrumenetation::didHandleEvent

We should clear scheduled pause if event listener doesn't execute JavaScript
otherwise JS execution will be paused in random place.

R=dgozman@chromium.org,pfeldman@chromium.org
==========

[kozy, 2016-04-15 01:00:40]

please take a look.

[kozy, 2016-04-15 01:03:55]

Patchset #2 (id:20001) has been deleted

[pfeldman, 2016-04-15 01:05:29]

My bad. This is probably good for a merge, but isn't it true for all the native
breakpoints? Should we use RAII instead of async allowNativeBreakpoint?

[pfeldman, 2016-04-15 01:06:38]

lgtm

[dgozman, 2016-04-15 01:46:28]

On 2016/04/15 01:05:29, pfeldman_ooo wrote:
> My bad. This is probably good for a merge, but isn't it true for all the
native
> breakpoints? Should we use RAII instead of async allowNativeBreakpoint?

Yeah, we will do InspectorInstrumentation::NativeBreakpoint in M52.

[kozy, 2016-04-15 02:20:36]

Description was changed from

==========
[DevTools] Bring back InspectorInstrumenetation::didHandleEvent

We should clear scheduled pause if event listener doesn't execute JavaScript
otherwise JS execution will be paused in random place.

R=dgozman@chromium.org,pfeldman@chromium.org
==========

to

==========
[DevTools] Bring back InspectorInstrumenetation::didHandleEvent

We should clear scheduled pause if event listener doesn't execute JavaScript
otherwise JS execution will be paused in random place.

R=dgozman@chromium.org,pfeldman@chromium.org
BUG=603792
==========

[kozy, 2016-04-15 02:21:08]

Description was changed from

==========
[DevTools] Bring back InspectorInstrumenetation::didHandleEvent

We should clear scheduled pause if event listener doesn't execute JavaScript
otherwise JS execution will be paused in random place.

R=dgozman@chromium.org,pfeldman@chromium.org
BUG=603792
==========

to

==========
[DevTools] Bring back InspectorInstrumenetation::didHandleEvent

We should clear scheduled pause if event listener doesn't execute JavaScript or
setTimeout expression contains syntax error otherwise JS execution will be
paused in random place.

R=dgozman@chromium.org,pfeldman@chromium.org
BUG=603792
==========

[kozy, 2016-04-15 02:25:16]

Please take another look. I've brought back cancelScheduledPause call after
timerFired too and added a test.

I'm working on writing doc about stepping in DevTools which was requested by
Yang in crbug.com/562067 and I'll introduce NativeErrorScope as part of this
work.

[dgozman, 2016-04-15 16:40:01]

https://codereview.chromium.org/1891113002/diff/80001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/break-on-set-timeout-with-syntax-error.html
(right):

https://codereview.chromium.org/1891113002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/break-on-set-timeout-with-syntax-error.html:33:
InspectorTest.evaluateInPage("executeSomeCode()");
I don't get how this test works.

https://codereview.chromium.org/1891113002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl
(right):

https://codereview.chromium.org/1891113002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl:138: void
cancelPauseOnNextStatement(const InspectorInstrumentationCookie&);
This should go to DOMDebugger.

[kozy, 2016-04-15 17:11:47]

All done!

https://codereview.chromium.org/1891113002/diff/80001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/break-on-set-timeout-with-syntax-error.html
(right):

https://codereview.chromium.org/1891113002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/break-on-set-timeout-with-syntax-error.html:33:
InspectorTest.evaluateInPage("executeSomeCode()");
On 2016/04/15 16:40:01, dgozman wrote:
> I don't get how this test works.

Done.

https://codereview.chromium.org/1891113002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl
(right):

https://codereview.chromium.org/1891113002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl:138: void
cancelPauseOnNextStatement(const InspectorInstrumentationCookie&);
On 2016/04/15 16:40:01, dgozman wrote:
> This should go to DOMDebugger.

Done.

[dgozman, 2016-04-15 17:19:31]

lgtm

[kozy, 2016-04-15 17:31:09]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-04-15 17:31:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1891113002/#ps100001
(title: " ")

[commit-bot: I haz the power, 2016-04-15 17:31:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1891113002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1891113002/100001

[commit-bot: I haz the power, 2016-04-15 18:51:12]

Description was changed from

==========
[DevTools] Bring back InspectorInstrumenetation::didHandleEvent

We should clear scheduled pause if event listener doesn't execute JavaScript or
setTimeout expression contains syntax error otherwise JS execution will be
paused in random place.

R=dgozman@chromium.org,pfeldman@chromium.org
BUG=603792
==========

to

==========
[DevTools] Bring back InspectorInstrumenetation::didHandleEvent

We should clear scheduled pause if event listener doesn't execute JavaScript or
setTimeout expression contains syntax error otherwise JS execution will be
paused in random place.

R=dgozman@chromium.org,pfeldman@chromium.org
BUG=603792
==========

[commit-bot: I haz the power, 2016-04-15 18:51:13]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-04-15 18:52:01]

Description was changed from

==========
[DevTools] Bring back InspectorInstrumenetation::didHandleEvent

We should clear scheduled pause if event listener doesn't execute JavaScript or
setTimeout expression contains syntax error otherwise JS execution will be
paused in random place.

R=dgozman@chromium.org,pfeldman@chromium.org
BUG=603792
==========

to

==========
[DevTools] Bring back InspectorInstrumenetation::didHandleEvent

We should clear scheduled pause if event listener doesn't execute JavaScript or
setTimeout expression contains syntax error otherwise JS execution will be
paused in random place.

R=dgozman@chromium.org,pfeldman@chromium.org
BUG=603792

Committed: https://crrev.com/3f447ebc494e1c3c0296689ca978831044fef623
Cr-Commit-Position: refs/heads/master@{#387660}
==========

[commit-bot: I haz the power, 2016-04-15 18:52:03]

Patchset 5 (id:??) landed as
https://crrev.com/3f447ebc494e1c3c0296689ca978831044fef623
Cr-Commit-Position: refs/heads/master@{#387660}