Stop fetching the next page if the first page has no content

Stop fetching the next page if the first page has no content

In DOM distiller, if the distilled content of the first page is empty,
it's very likely that the page is not good for distillation, so fetching
the next page doesn't make sense.

BUG=602139
Committed: https://crrev.com/6d72911b0cb47f5519288325fc502470815b9e7a
Cr-Commit-Position: refs/heads/master@{#387759}

[wychen, 2016-04-15 00:38:09]

wychen@chromium.org changed reviewers:
+ mdjones@chromium.org

[wychen, 2016-04-15 00:38:10]

PTAL.

The diff here is not very smart about changing indent level. "git diff -w" is
better.

[mdjones, 2016-04-15 21:57:35]

https://codereview.chromium.org/1891103002/diff/1/components/dom_distiller/co...
File components/dom_distiller/core/distiller.cc (right):

https://codereview.chromium.org/1891103002/diff/1/components/dom_distiller/co...
components/dom_distiller/core/distiller.cc:170: bool content_not_empty = false;
Can we flip the name/logic to be positive instead of negative? i.e.
content_not_empty -> content_empty.

[wychen, 2016-04-15 22:02:10]

https://codereview.chromium.org/1891103002/diff/1/components/dom_distiller/co...
File components/dom_distiller/core/distiller.cc (right):

https://codereview.chromium.org/1891103002/diff/1/components/dom_distiller/co...
components/dom_distiller/core/distiller.cc:170: bool content_not_empty = false;
On 2016/04/15 21:57:35, mdjones wrote:
> Can we flip the name/logic to be positive instead of negative? i.e.
> content_not_empty -> content_empty.

Done.

[mdjones, 2016-04-15 22:12:47]

lgtm

[wychen, 2016-04-15 22:31:36]

The CQ bit was checked by wychen@chromium.org

[commit-bot: I haz the power, 2016-04-15 22:32:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1891103002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1891103002/20001

[commit-bot: I haz the power, 2016-04-16 00:09:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-16 00:10:21]

Description was changed from

==========
Stop fetching the next page if the first page has no content

In DOM distiller, if the distilled content of the first page is empty,
it's very likely that the page is not good for distillation, so fetching
the next page doesn't make sense.

BUG=602139
==========

to

==========
Stop fetching the next page if the first page has no content

In DOM distiller, if the distilled content of the first page is empty,
it's very likely that the page is not good for distillation, so fetching
the next page doesn't make sense.

BUG=602139

Committed: https://crrev.com/6d72911b0cb47f5519288325fc502470815b9e7a
Cr-Commit-Position: refs/heads/master@{#387759}
==========

[commit-bot: I haz the power, 2016-04-16 00:10:22]

Patchset 2 (id:??) landed as
https://crrev.com/6d72911b0cb47f5519288325fc502470815b9e7a
Cr-Commit-Position: refs/heads/master@{#387759}