chrome/common/translate/translate_helper_metrics.h - Issue 18911002: Move language detection to chrome/common/.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/translate/translate_helper_metrics.h

Issue 18911002: Move language detection to chrome/common/. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Full test + rebase Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/common/translate/language_detection_util.cc ('K') | « chrome/common/translate/language_detection_util_unittest.cc ('k') | chrome/common/translate/translate_helper_metrics.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_RENDERER_TRANSLATE_TRANSLATE_HELPER_METRICS_H_	5 #ifndef CHROME_COMMON_TRANSLATE_TRANSLATE_HELPER_METRICS_H_
	Takashi Toyoshima 2013/07/10 17:14:21 Originally, TranslateHelperMetrics is named becaus Originally, TranslateHelperMetrics is named because TranslateHelper uses it. So this class should have another name, e.g., TranslateCommonMetrics.
6 #define CHROME_RENDERER_TRANSLATE_TRANSLATE_HELPER_METRICS_H_	6 #define CHROME_COMMON_TRANSLATE_TRANSLATE_HELPER_METRICS_H_

7	7

8 #include <string>	8 #include <string>

9	9

10 #include "base/time/time.h"	10 #include "base/time/time.h"

11	11

12 namespace TranslateHelperMetrics {	12 namespace TranslateHelperMetrics {

13	13

14 // An indexing type to query each UMA entry name via GetMetricsName() function.	14 // An indexing type to query each UMA entry name via GetMetricsName() function.

15 // Note: \|kMetricsEntries\| should be updated when a new entry is added here.	15 // Note: \|kMetricsEntries\| should be updated when a new entry is added here.

16 enum MetricsNameIndex {	16 enum MetricsNameIndex {

(...skipping 81 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
98	98

99 // Called when CLD agreed on a language which is different, but in the similar	99 // Called when CLD agreed on a language which is different, but in the similar

100 // language list.	100 // language list.

101 void ReportSimilarLanguageMatch(bool match);	101 void ReportSimilarLanguageMatch(bool match);

102	102

103 // Gets UMA name for an entry specified by \|index\|.	103 // Gets UMA name for an entry specified by \|index\|.

104 const char* GetMetricsName(MetricsNameIndex index);	104 const char* GetMetricsName(MetricsNameIndex index);

105	105

106 } // namespace TranslateHelperMetrics	106 } // namespace TranslateHelperMetrics

107	107

108 #endif // CHROME_RENDERER_TRANSLATE_TRANSLATE_HELPER_METRICS_H_	108 #endif // CHROME_COMMON_TRANSLATE_TRANSLATE_HELPER_METRICS_H_

OLD	NEW