src/compiler/x64/code-generator-x64.cc - Issue 1891033002: [Atomics] Remove Atomics code stubs; use TF ops

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/x64/code-generator-x64.cc

Issue 1891033002: [Atomics] Remove Atomics code stubs; use TF ops (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: fix unused variables Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/x64/code-generator-x64.cc

diff --git a/src/compiler/x64/code-generator-x64.cc b/src/compiler/x64/code-generator-x64.cc

index e756ee2b2b99a46ba6ea45aec1066d06835a0eab..7f2a6c23abe9d38852f25d10232cb255fabae95a 100644

--- a/src/compiler/x64/code-generator-x64.cc

+++ b/src/compiler/x64/code-generator-x64.cc

@@ -1767,6 +1767,13 @@ void CodeGenerator::AssembleArchInstruction(Instruction* instr) {

case kX64StackCheck:

__ CompareRoot(rsp, Heap::kStackLimitRootIndex);

break;

+ case kAtomicLoadInt8:

+ case kAtomicLoadUint8:

+ case kAtomicLoadInt16:

+ case kAtomicLoadUint16:

+ case kAtomicLoadWord32:

+ UNREACHABLE(); // Won't be generated by instruction selector.

+ break;

}

} // NOLINT(readability/fn_size)