service/taskqueue: Add NewPOSTTask, remove NewTask

service/taskqueue: Add NewPOSTTask, remove NewTask

Add NewPOSTTask, which mirrors the method of the same name in
AppEngine's Go task queue SDK.

Remove NewTask from the taskqueue Interface, since it was basically
useless.

BUG=

Committed: https://github.com/luci/gae/commit/1ebcc92d2315f2c524c569f26b95a7e378d56ba9

[dnj, 2016-04-16 01:16:57]

dnj@chromium.org changed reviewers:
+ iannucci@chromium.org

[dnj, 2016-04-16 01:16:57]

PTAL, forgot to send this earlier!

[iannucci, 2016-04-16 01:26:43]

https://chromiumcodereview.appspot.com/1890983004/diff/1/impl/memory/taskqueu...
File impl/memory/taskqueue_test.go (right):

https://chromiumcodereview.appspot.com/1890983004/diff/1/impl/memory/taskqueu...
impl/memory/taskqueue_test.go:69: t := &tqS.Task{Path: ""}
Task{}

https://chromiumcodereview.appspot.com/1890983004/diff/1/service/taskqueue/ty...
File service/taskqueue/types.go (left):

https://chromiumcodereview.appspot.com/1890983004/diff/1/service/taskqueue/ty...
service/taskqueue/types.go:32: type RetryOptions struct {
why did these get moved?

[dnj, 2016-04-16 01:50:27]

https://chromiumcodereview.appspot.com/1890983004/diff/1/impl/memory/taskqueu...
File impl/memory/taskqueue_test.go (right):

https://chromiumcodereview.appspot.com/1890983004/diff/1/impl/memory/taskqueu...
impl/memory/taskqueue_test.go:69: t := &tqS.Task{Path: ""}
On 2016/04/16 01:26:43, iannucci wrote:
> Task{}

Done.

https://chromiumcodereview.appspot.com/1890983004/diff/1/service/taskqueue/ty...
File service/taskqueue/types.go (left):

https://chromiumcodereview.appspot.com/1890983004/diff/1/service/taskqueue/ty...
service/taskqueue/types.go:32: type RetryOptions struct {
On 2016/04/16 01:26:43, iannucci wrote:
> why did these get moved?

Now that I have a "task.go", it seems reasonable to put the Task and its
RetryOptions in there.

[dnj, 2016-04-18 16:43:27]

(Pang)

[iannucci, 2016-04-18 22:07:46]

lgtm

[dnj, 2016-04-18 23:15:58]

The CQ bit was checked by dnj@chromium.org

[commit-bot: I haz the power, 2016-04-18 23:16:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1890983004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1890983004/20001

[commit-bot: I haz the power, 2016-04-18 23:21:41]

Description was changed from

==========
service/taskqueue: Add NewPOSTTask, remove NewTask

Add NewPOSTTask, which mirrors the method of the same name in
AppEngine's Go task queue SDK.

Remove NewTask from the taskqueue Interface, since it was basically
useless.

BUG=
==========

to

==========
service/taskqueue: Add NewPOSTTask, remove NewTask

Add NewPOSTTask, which mirrors the method of the same name in
AppEngine's Go task queue SDK.

Remove NewTask from the taskqueue Interface, since it was basically
useless.

BUG=

Committed:
https://github.com/luci/gae/commit/1ebcc92d2315f2c524c569f26b95a7e378d56ba9
==========

[commit-bot: I haz the power, 2016-04-18 23:21:42]

Committed patchset #2 (id:20001) as
https://github.com/luci/gae/commit/1ebcc92d2315f2c524c569f26b95a7e378d56ba9