pkg/analyzer: support latest pkg/crypto version

pkg/analyzer: support latest pkg/crypto version

BUG= https://github.com/dart-lang/sdk/issues/26138
R=brianwilkerson@google.com, paulberry@google.com

Committed: https://github.com/dart-lang/sdk/commit/5b5312a67c1c5f6c40564a9f9278e2011099cd89

[kevmoo, 2016-04-14 21:48:53]

kevmoo@google.com changed reviewers:
+ brianwilkerson@google.com, nweiz@google.com, paulberry@google.com

[kevmoo, 2016-04-14 21:48:54]

Here's a start

Sadly, I can't continue this until a number of io tests that use pkg/convert are
migrated, too

tests/standalone/io/http_auth_digest_test.dart:5:import
"package:crypto/crypto.dart";
tests/standalone/io/http_auth_test.dart:5:import "package:crypto/crypto.dart";
tests/standalone/io/http_proxy_advanced_test.dart:5:import
"package:crypto/crypto.dart";
tests/standalone/io/http_proxy_test.dart:5:import "package:crypto/crypto.dart";
tests/standalone/io/web_socket_compression_test.dart:17:import
"package:crypto/crypto.dart";
tests/standalone/io/web_socket_test.dart:16:import "package:crypto/crypto.dart";

[nweiz, 2016-04-14 21:53:09]

https://codereview.chromium.org/1890973003/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/incremental_cache.dart (right):

https://codereview.chromium.org/1890973003/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/incremental_cache.dart:307: return
md5.convert(digestList).bytes;
All you're doing here is a very roundabout way of adding a bunch of ints to a
list and then passing them wholesale to [md5.convert]. If you want to
iteratively build the hash, you need to pass a ChunkedConversionSink<Digest> to
[md5.startChunkedConversion].

[Brian Wilkerson, 2016-04-14 21:53:13]

> I can't continue this until a number of io tests that use pkg/convert are
migrated, too.

Where are these tests?

https://codereview.chromium.org/1890973003/diff/1/pkg/analyzer/pubspec.yaml
File pkg/analyzer/pubspec.yaml (right):

https://codereview.chromium.org/1890973003/diff/1/pkg/analyzer/pubspec.yaml#n...
pkg/analyzer/pubspec.yaml:2: version: 0.27.4-dev
We usually use an alpha version ("0.27.4-alpha.1").

[kevmoo, 2016-04-14 23:13:35]

PTAL

https://codereview.chromium.org/1890973003/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/incremental_cache.dart (right):

https://codereview.chromium.org/1890973003/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/incremental_cache.dart:307: return
md5.convert(digestList).bytes;
On 2016/04/14 21:53:09, nweiz wrote:
> All you're doing here is a very roundabout way of adding a bunch of ints to a
> list and then passing them wholesale to [md5.convert]. If you want to
> iteratively build the hash, you need to pass a ChunkedConversionSink<Digest>
to
> [md5.startChunkedConversion].

Done.

https://codereview.chromium.org/1890973003/diff/1/pkg/analyzer/pubspec.yaml
File pkg/analyzer/pubspec.yaml (right):

https://codereview.chromium.org/1890973003/diff/1/pkg/analyzer/pubspec.yaml#n...
pkg/analyzer/pubspec.yaml:2: version: 0.27.4-dev
On 2016/04/14 21:53:12, Brian Wilkerson wrote:
> We usually use an alpha version ("0.27.4-alpha.1").

Acknowledged.

[Brian Wilkerson, 2016-04-14 23:23:01]

lgtm, but you should wait for Paul's review.

[Paul Berry, 2016-04-15 13:16:00]

lgtm

https://codereview.chromium.org/1890973003/diff/80001/pkg/analyzer/lib/src/su...
File pkg/analyzer/lib/src/summary/incremental_cache.dart (right):

https://codereview.chromium.org/1890973003/diff/80001/pkg/analyzer/lib/src/su...
pkg/analyzer/lib/src/summary/incremental_cache.dart:312: // TODO: this call to
`close` should not be needed. Can be removed once
The convention in analyzer source is for each TODO to be followed by a username,
e.g. "TODO(kevmoo)".  If you don't feel comfortable attaching your username to
this todo, you can use mine ("TODO(paulberry)").

https://codereview.chromium.org/1890973003/diff/80001/pkg/analyzer/pubspec.yaml
File pkg/analyzer/pubspec.yaml (right):

https://codereview.chromium.org/1890973003/diff/80001/pkg/analyzer/pubspec.ya...
pkg/analyzer/pubspec.yaml:2: version: 0.27.4-alpha.1
Are you intending to publish this change immediately?

In analyzer the convention is that we only change the "version" string when we
are just about to publish.  If you are not intending to publish a new version of
analyzer right now, just leave it as "0.27.3".

[kevmoo, 2016-04-15 16:57:35]

https://codereview.chromium.org/1890973003/diff/80001/pkg/analyzer/lib/src/su...
File pkg/analyzer/lib/src/summary/incremental_cache.dart (right):

https://codereview.chromium.org/1890973003/diff/80001/pkg/analyzer/lib/src/su...
pkg/analyzer/lib/src/summary/incremental_cache.dart:312: // TODO: this call to
`close` should not be needed. Can be removed once
On 2016/04/15 13:16:00, Paul Berry wrote:
> The convention in analyzer source is for each TODO to be followed by a
username,
> e.g. "TODO(kevmoo)".  If you don't feel comfortable attaching your username to
> this todo, you can use mine ("TODO(paulberry)").

Done.

https://codereview.chromium.org/1890973003/diff/80001/pkg/analyzer/pubspec.yaml
File pkg/analyzer/pubspec.yaml (right):

https://codereview.chromium.org/1890973003/diff/80001/pkg/analyzer/pubspec.ya...
pkg/analyzer/pubspec.yaml:2: version: 0.27.4-alpha.1
On 2016/04/15 13:16:00, Paul Berry wrote:
> Are you intending to publish this change immediately?
> 
> In analyzer the convention is that we only change the "version" string when we
> are just about to publish.  If you are not intending to publish a new version
of
> analyzer right now, just leave it as "0.27.3".

Done.

[kevmoo, 2016-04-15 16:59:41]

Description was changed from

==========
pkg/analyzer: support latest pkg/crypto version

BUG= https://github.com/dart-lang/sdk/issues/26138
==========

to

==========
pkg/analyzer: support latest pkg/crypto version

BUG= https://github.com/dart-lang/sdk/issues/26138
R=brianwilkerson@google.com, paulberry@google.com

Committed:
https://github.com/dart-lang/sdk/commit/5b5312a67c1c5f6c40564a9f9278e2011099cd89
==========

[kevmoo, 2016-04-15 16:59:43]

Committed patchset #6 (id:100001) manually as
5b5312a67c1c5f6c40564a9f9278e2011099cd89 (presubmit successful).

[nweiz, 2016-04-15 19:05:11]

https://codereview.chromium.org/1890973003/diff/80001/pkg/analyzer/lib/src/su...
File pkg/analyzer/lib/src/summary/incremental_cache.dart (right):

https://codereview.chromium.org/1890973003/diff/80001/pkg/analyzer/lib/src/su...
pkg/analyzer/lib/src/summary/incremental_cache.dart:314: digestSink.close();
Heads up: this call will actually throw an exception once the crypto issue is
fixed.

[Paul Berry, 2016-04-15 19:11:01]

On 2016/04/15 19:05:11, nweiz wrote:
>
https://codereview.chromium.org/1890973003/diff/80001/pkg/analyzer/lib/src/su...
> File pkg/analyzer/lib/src/summary/incremental_cache.dart (right):
> 
>
https://codereview.chromium.org/1890973003/diff/80001/pkg/analyzer/lib/src/su...
> pkg/analyzer/lib/src/summary/incremental_cache.dart:314: digestSink.close();
> Heads up: this call will actually throw an exception once the crypto issue is
> fixed.

Which crypto issue?