Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1890973002: Clean up hints after a new hint was introduced (Closed)

Created:
4 years, 8 months ago by Brian Wilkerson
Modified:
4 years, 8 months ago
Reviewers:
jwren
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -54 lines) Patch
M pkg/analysis_server/lib/plugin/analysis/navigation/navigation_core.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/plugin/analysis/occurrences/occurrences_core.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_analysis.dart View 1 chunk +1 line, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/imported_reference_contributor.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/override_contributor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/static_member_contributor.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/type_member_contributor.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/constant.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error.dart View 3 chunks +3 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/sdk.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summary_sdk.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/task/dart_work_manager.dart View 1 chunk +1 line, -7 lines 0 comments Download
M pkg/analyzer/lib/src/task/html_work_manager.dart View 1 chunk +1 line, -7 lines 0 comments Download
M pkg/analyzer/lib/src/task/options_work_manager.dart View 1 chunk +1 line, -7 lines 0 comments Download
M pkg/analyzer/lib/src/task/strong/checker.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/context/mock_sdk.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analyzer_cli/lib/src/perf_report.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 8 months ago (2016-04-14 20:09:50 UTC) #2
jwren
On 2016/04/14 20:09:50, Brian Wilkerson wrote: LGTM
4 years, 8 months ago (2016-04-14 20:11:49 UTC) #3
Brian Wilkerson
4 years, 8 months ago (2016-04-14 20:15:39 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
21a1b757c149606591eb62bb2b648b390277b182 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698