Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 1890943002: Add a utility for dumping inferred types from summary files. (Closed)

Created:
4 years, 8 months ago by Paul Berry
Modified:
4 years, 8 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a utility for dumping inferred types from summary files. This should be useful in validating the correctness of AST-based summary type inference. R=brianwilkerson@google.com, scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/0f7c0a18e237a84863368ee97c35aad1f9c51a61

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+227 lines, -0 lines) Patch
A pkg/analyzer/tool/summary/dump_inferred_types.dart View 1 chunk +227 lines, -0 lines 1 comment Download

Messages

Total messages: 6 (2 generated)
Paul Berry
4 years, 8 months ago (2016-04-14 18:44:25 UTC) #2
Brian Wilkerson
lgtm https://codereview.chromium.org/1890943002/diff/1/pkg/analyzer/tool/summary/dump_inferred_types.dart File pkg/analyzer/tool/summary/dump_inferred_types.dart (right): https://codereview.chromium.org/1890943002/diff/1/pkg/analyzer/tool/summary/dump_inferred_types.dart#newcode1 pkg/analyzer/tool/summary/dump_inferred_types.dart:1: // Copyright (c) 2015, the Dart project authors. ...
4 years, 8 months ago (2016-04-14 18:53:18 UTC) #3
scheglov
LGTM
4 years, 8 months ago (2016-04-14 20:00:11 UTC) #4
Paul Berry
4 years, 8 months ago (2016-04-14 20:10:18 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0f7c0a18e237a84863368ee97c35aad1f9c51a61 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698